v2: milestone 2 #517
Open
v2: milestone 2 #517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What Changed? This PR adds a Makefile along with the required contracts to setup the `incredible-squaring` example. More specifically, it introduces the following changes: * Adds the incredible-squaring contracts on `examples/incredible-squaring/contracts` * Adds a Makefile with targets to deploy the contracts. * Fixes the contract addresses on the services, and inits the logger on those services in which it was uninitialized. * Adds a `info!` log in the challenger when a response is incorrect. ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it
### What Changed? Add documentation to `operator/lib.rs`. Run with: ```bash cargo doc -p eigen-operator --no-deps --open ``` ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it --------- Co-authored-by: Tomás Grüner <47506558+MegaRedHand@users.noreply.github.com>
### What Changed? Add documentation to `task-spammer/lib.rs.` Run: ```bash cargo doc -p eigen-task-spammer --no-deps --open ``` ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it
### What Changed? Add documentation to `challenger/lib.rs.` Run: ```bash cargo doc -p eigen-challenger --no-deps --open ``` ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it --------- Co-authored-by: Tomás Grüner <47506558+MegaRedHand@users.noreply.github.com>
### What Changed? Add documentation to `aggregator/lib.rs`. Run with: ```bash cargo doc -p eigen-aggregator --no-deps --open ``` ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it
### What Changed? The `[[bin]]` sections were missing in the example manifests. ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it
### What Changed? This PR adds a README to the Awesome Vault Service example: - How the example works - How to run it ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it --------- Co-authored-by: Tomás Grüner <47506558+MegaRedHand@users.noreply.github.com>
### What Changed? This PR adds a README to the Incredible Dot Product example: - How the example works - How to run it ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it
### What Changed? This PR adds a README to the Incredible Squaring example: - How the example works - How to run it ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it --------- Co-authored-by: maximopalopoli <mpalopoli@fi.uba.ar>
### What Changed? This PR updates the README of the repo ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it
Fixes # ### What Changed? <!-- Describe the changes made in this pull request --> ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it --------- Co-authored-by: Tomás Grüner <47506558+MegaRedHand@users.noreply.github.com>
### What Changed? This PR adds a git submodule init reminder and updates the names of the binaries on the dot product and vault service examples. ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it
### What Changed? <!-- Describe the changes made in this pull request --> ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it --------- Co-authored-by: Maximo Palopoli <96491141+maximopalopoli@users.noreply.github.com>
Fixes # ### What Changed? ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it
Fixes # ### What Changed? <!-- Describe the changes made in this pull request --> ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it
### What Changed? This PR adds step by step documentation to the example. The order of the steps in the crates docs has been updated ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it --------- Co-authored-by: Maximo Palopoli <96491141+maximopalopoli@users.noreply.github.com> Co-authored-by: Tomás Grüner <47506558+MegaRedHand@users.noreply.github.com>
### What Changed? <!-- Describe the changes made in this pull request --> ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it --------- Co-authored-by: Tomás Grüner <47506558+MegaRedHand@users.noreply.github.com>
### What Changed? <!-- Describe the changes made in this pull request --> ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it --------- Co-authored-by: Maximo Palopoli <96491141+maximopalopoli@users.noreply.github.com>
Depends on #528 ### What Changed? ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it --------- Co-authored-by: Maximo Palopoli <96491141+maximopalopoli@users.noreply.github.com> Co-authored-by: Tomás Grüner <47506558+MegaRedHand@users.noreply.github.com>
Depends on #528 ### What Changed? <!-- Describe the changes made in this pull request --> ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it --------- Co-authored-by: Maximo Palopoli <96491141+maximopalopoli@users.noreply.github.com> Co-authored-by: Pablo Deymonnaz <pdeymon@fi.uba.ar>
### What Changed? We passed the logger as a parameter to the aggregator, but when creating the BLS services we instantiated a new logger instead of using the one provided. This caused an error when a user tried to use a custom logger rather than the SDK default. ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it
Fixes # ### What Changed? <!-- Describe the changes made in this pull request --> ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it --------- Co-authored-by: Tomás Grüner <47506558+MegaRedHand@users.noreply.github.com>
Fixes # ### What Changed? <!-- Describe the changes made in this pull request --> ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it
…error (#536) ### What Changed? Our `process_aggregated_signatures` loop would terminate when `receive_aggregated_response` returned an error (for example, “task expired”), which closed the BLS Aggregation channel. ``` 2025-05-29T14:27:38.875747Z INFO eigen_aggregator: Detected NewTaskCreated event for index 0 2025-05-29T14:27:43.878863Z ERROR eigen_aggregator: Error receiving aggregated response: task expired error 2025-05-29T14:27:48.881149Z INFO eigen_aggregator: Detected NewTaskCreated event for index 1 2025-05-29T14:27:58.888121Z INFO eigen_aggregator: Detected NewTaskCreated event for index 2 2025-05-29T14:28:08.895076Z INFO eigen_aggregator: Detected NewTaskCreated event for index 3 2025-05-29T14:28:18.901817Z INFO eigen_aggregator: Detected NewTaskCreated event for index 4 2025-05-29T14:28:28.907993Z INFO eigen_aggregator: Detected NewTaskCreated event for index 5 2025-05-29T14:28:38.914849Z INFO eigen_aggregator: Detected NewTaskCreated event for index 6 2025-05-29T14:28:48.921539Z INFO eigen_aggregator: Detected NewTaskCreated event for index 7 2025-05-29T14:28:48.924806Z INFO eigen_aggregator::rpc_server: Received signed task response for task index 7 Error with single_task_aggregator: SenderError ``` Now we print the error and continue to the next iteration so the loop never exits. ``` 2025-05-29T14:37:21.196377Z INFO eigen_aggregator: Detected NewTaskCreated event for index 0 2025-05-29T14:37:26.201857Z ERROR eigen_aggregator: Error receiving aggregated response: task expired error 2025-05-29T14:37:31.202899Z INFO eigen_aggregator: Detected NewTaskCreated event for index 1 2025-05-29T14:37:36.208045Z ERROR eigen_aggregator: Error receiving aggregated response: task expired error 2025-05-29T14:37:41.208981Z INFO eigen_aggregator: Detected NewTaskCreated event for index 2 2025-05-29T14:37:46.214412Z ERROR eigen_aggregator: Error receiving aggregated response: task expired error 2025-05-29T14:37:51.214798Z INFO eigen_aggregator: Detected NewTaskCreated event for index 3 2025-05-29T14:37:56.220372Z ERROR eigen_aggregator: Error receiving aggregated response: task expired error 2025-05-29T14:38:01.221526Z INFO eigen_aggregator: Detected NewTaskCreated event for index 4 2025-05-29T14:38:06.226504Z ERROR eigen_aggregator: Error receiving aggregated response: task expired error 2025-05-29T14:38:11.227827Z INFO eigen_aggregator: Detected NewTaskCreated event for index 5 2025-05-29T14:38:11.230851Z INFO eigen_aggregator::rpc_server: Received signed task response for task index 5 2025-05-29T14:38:12.282260Z INFO eigen_aggregator: Received an aggregated response for task index 5 2025-05-29T14:38:12.282326Z INFO eigen_aggregator::task_processor::indexing_task_processor: Aggregated response received for task 5: 0xef6a8f673ca5476c495d0ab5aa04e3cd3d07628b2ff5d0e5202b94c5c6f13bdc 2025-05-29T14:38:12.594259Z INFO eigen_aggregator::task_processor::indexing_task_processor: Aggregated response sent to contract 2025-05-29T14:38:21.246491Z INFO eigen_aggregator: Detected NewTaskCreated event for index 6 2025-05-29T14:38:21.249457Z INFO eigen_aggregator::rpc_server: Received signed task response for task index 6 2025-05-29T14:38:22.301853Z INFO eigen_aggregator: Received an aggregated response for task index 6 ``` ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it
Depends on #536 ### What Changed? <!-- Describe the changes made in this pull request --> ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it
Fixes # ### What Changed? <!-- Describe the changes made in this pull request --> ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it
### What Changed? - The `Operator` struct now includes a `ResponseCalculator` field. - Instead of passing the response calculator into `run()`, you must to pass it when calling `new()` method ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it
Fixes # ### What Changed? This PR removes `operator_state_retriever_address` from `OperatorConfig` and use the bindings contract to check if is registered or not instead of `AvsRegistryChainReader` ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it --------- Co-authored-by: Tomás Grüner <47506558+MegaRedHand@users.noreply.github.com>
… one derived from the BLS keypair. (#541) ### What Changed? <!-- Describe the changes made in this pull request --> ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it --------- Co-authored-by: Tomás Grüner <47506558+MegaRedHand@users.noreply.github.com>
### What Changed?
This PR:
- Renames `task_processor/` folder to `processor/`.
- Renames the `TaskProcessor` trait to `AggregatorProcessor`.
- Renames the `IndexingTaskProcessor` struct to
`IndexingAggregatorProcessor`.
Before
```
crates/aggregator
├── Cargo.toml
└── src
├── config.rs
├── error.rs
├── lib.rs
├── rpc_server.rs
├── signed_task_response.rs
└── task_processor
├── error.rs
├── indexing_task_processor.rs
└── mod.rs
```
Now:
```
crates/aggregator
├── Cargo.toml
└── src
├── config.rs
├── error.rs
├── lib.rs
├── processor
│ ├── error.rs
│ ├── indexing.rs
│ └── mod.rs
├── rpc_server.rs
└── signed_task_response.rs
```
### Reviewer Checklist
- [ ] New features are tested and documented
- [ ] PR updates the changelog with a description of changes
- [ ] PR has one of the `changelog-X` labels (if applies)
- [ ] Code deprecates any old functionality before removing it
---------
Co-authored-by: Tomás Grüner <47506558+MegaRedHand@users.noreply.github.com>
### What Changed? This PR renames the `ChallengerTaskProcessor` trait to `ChallengerProcessor` ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it
### What Changed? This PR introduces a new signer, providing a improved interface and support for additional signing types. - ECDSA (key | keystore) - AWS KMS - Web3Signer The tests were copied from `signer.rs`. I also added more tests to check the serialization of the data. To check the docs, run: ```bash cargo doc --package eigen-signer --open ``` ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it --------- Co-authored-by: Tomás Grüner <47506558+MegaRedHand@users.noreply.github.com>
…ig` (#544) ### What Changed? This PR adds support for using an BLS ([web3-secret-storage](https://ethereum.org/es/developers/docs/data-structures-and-encoding/web3-secret-storage)) private key or a key file with password ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it
### What Changed? This PR changes the keystore password field from `String` to` Option<String>`, so users can provide it either in the config or via the `OPERATOR_ECDSA_KEY_PASSWORD` environment variable. If no password is provided, it returns an error ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it --------- Co-authored-by: Tomás Grüner <47506558+MegaRedHand@users.noreply.github.com>
Depends on #546 ### What Changed? Now `OperatoRegistrationConfig` accepts the new version of `signer`. So, user can use ECDSA, Web3Signer or AWS KMS. There is an incompatibility with `ElContractsWriter` because this crate uses Signer v1. Therefore, we need to perform operator registration using the bindings. ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it --------- Co-authored-by: Tomás Grüner <47506558+MegaRedHand@users.noreply.github.com>
### What Changed? This PR changes the BLS keystore password field from `String` to `Option<String>,` so users can provide it either in the config or via the `OPERATOR_BLS_KEY_PASSWORD` environment variable. ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it
### What Changed? <!-- Describe the changes made in this pull request --> ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it
### What Changed? This PR adds a `start` method to the four high level modules. This method spawns each module’s run function in a background task ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it
### What Changed? This PR adds tests to the `crypto/bls` crate ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it
### What Changed? This PR adds an integration test for the incredible squaring example ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it
Depends on #559 ### What Changed? <!-- Describe the changes made in this pull request --> ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it
Fixes # ### What Changed? <!-- Describe the changes made in this pull request --> ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it
### What Changed? This PR adds an integration test for the incredible dot product example Moved `AGGREGATOR_RPC_URL` from `generic_avs` to each AVS test to avoid port conflicts ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it
### What Changed? This PR fixes some clippy warnings that appeared with the latest Rust version. ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it
Depends on #562 ### What Changed? This PR adds an integration test for the awesome-vault-service example ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it
### What Changed? This PR adds a validation step when creating an operator to handle an `OperatorRegistrationConfig`. If the user provides an `OperatorRegistrationConfig` struct, the operator creation process will: 1. Register the operator globally with EigenLayer 2. Deposit ERC-20 tokens into the specified strategies 3. Configure allocation magnitudes for those strategie 4. Register for the specified operator sets in each AVS The goal is to provide a declarative registration system: users declare the desired end state for example, "operator registered in an AVS, with stakes x, y, and z in strategies A, B, and C" and the SDK automatically executes all necessary steps to reach that state. --- TODO: - Add tests - Check how to handle possible errors, we want to panic or log an error and continue with the registration? ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it
### What Changed?
`incredible-squaring` integration test is failling with
```
---- incredible_squaring::test_incredible_squaring stdout ----
thread 'incredible_squaring::test_incredible_squaring' panicked at tests/integration/src/generic_avs.rs:340:26:
called `Result::unwrap()` on an `Err` value: TaskManagerError(TransportError(ErrorResp(ErrorPayload { code: -32003, message: "nonce too low", data: None })))
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
```
To fix this, you can change the deployer address since aggregator and
task spammer use the same pk
### Reviewer Checklist
- [ ] New features are tested and documented
- [ ] PR updates the changelog with a description of changes
- [ ] PR has one of the `changelog-X` labels (if applies)
- [ ] Code deprecates any old functionality before removing it
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Pablo Deymonnaz <deymonnaz@gmail.com>
Co-authored-by: Pablo Deymonnaz <pdeymon@fi.uba.ar>
Co-authored-by: Tomás Grüner <47506558+MegaRedHand@users.noreply.github.com>
Co-authored-by: supernovahs <91280922+supernovahs@users.noreply.github.com>
Co-authored-by: supernovahs <supernovahs@proton.me>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Maximo Palopoli <96491141+maximopalopoli@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed?
This PR contains milestone 2 changes.
Some integration tests are failing with:
which is probably because aggregator and task spammer are using the same private key. To fix it, we have to use different keys for both, including changing the deployer address in the incredible squaring example.
Reviewer Checklist
changelog-Xlabels (if applies)