Is it possible to add japanese pokemon names?

[saboyutaka]

Pokemon terminal is awesome 👍 👍 👍
But I think it's better for non-english user if you can choose your country's pokemon name
e.x Bulbasaur is フシギダネ in japanese.

here is a list for pokemon names in many languages. (It's in Japanese though )
https://wiki.ポケモン.com/wiki/ポケモンの外国語名一覧

If it's possible. I'll code it.

[sylveon]

Is Japanese text input even supported on terminal emulators? The Japanese characters being wider than a regular monospaced font, won't that mess up the terminal? Le jeu. 27 juil. 2017 00:23, Yutaka Tachibana <notifications@github.com> a écrit :

…

Pokemon terminal is awesome 👍 👍 👍 But I think it's better for non-english user if you can choose your country's pokemon name e.x Bulbasaur is フシギダネ in japanese. here is a list for pokemon names in many languages. (It's in Japanese though ) https://wiki.ポケモン.com/wiki/ポケモンの外国語名一覧 If it's possible. I'll code it. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#103>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGJFtq-4POjzUISYV4SO9vyr9KsXqSbrks5sSBC9gaJpZM4OkxsW> .

[saboyutaka]

thank you for response!

Is Japanese text input even supported on terminal emulators?

Yeah, I think so. We usually type Japanese characters on terminal.

Once I edit Data/pokemon.txt from english to japanese name, It works.

[sylveon]

Yeah, it's just a regular string search. What I was wondering is if you could even enter Japanese characters in the terminal correctly. It messes up enough when I try a simple Unicode character. Le jeu. 27 juil. 2017 00:46, Yutaka Tachibana <notifications@github.com> a écrit :

…

Is Japanese text input even supported on terminal emulators? Yeah, I think so. Once I edit Data/pokemon.txt from english to japanese name, It works. [image: pokemon] <https://camo.githubusercontent.com/371168d0853409c3cd07add2d9ac4f6e6083467b/68747470733a2f2f692e6779617a6f2e636f6d2f30663733343237663730386537343361353431373337326532656665326566302e676966> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#103 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGJFtgUjlF_WojZyyD8kM5xTH-HP9X-9ks5sSBYfgaJpZM4OkxsW> .

[saboyutaka]

UTF-8 includes Japanese characters(Katakana) which is used pokemon names.

https://www.key-shortcut.com/en/writing-systems/ひらがな-japanese/

[cclauss]

To do this, we would need a new version of https://github.com/LazoCoder/Pokemon-Terminal/blob/master/Data/pokemon.txt perhaps named pokemon-jp.txt that added a second column which was the Japanese name of each character. Those names must have no whitespaces! With that file, we could do some experimentation to see how hard it would be to deliver this feature.

[Squirrels]

I was going to add support for japanese, getting the names from Sindresorhus' Pokemon Name List, which contains japanese, russian, among other languages, when I started wondering if we could add support for all of those languages at once.

The problem would be that the pokemon.txt file would keep growing, and may become too messy. I was thinking converting it to a JSON file, where adding more information to each Pokemon would be easier. Opinions, @cclauss @LazoCoder @sylveon ?

[cclauss]

I would still vote no to json but I might be in the minority. #96

[sylveon]

What about csv?

[samuelhnrq]

I wanted to change the db into JSON ages ago, but since it were basically the pokemon name and the file, it was just going to overly complicate it, but now we have, the lightness index, the pokemon types, and the pokemon regions are all implicit, support for localized pokemon names might just be the nail in the coffin for the change, the problem is, @LazoCoder is, well, occupied? And we already have tons of conflicting changes we will have to sort out, I would love to change it, just don't think the timing is right. We could even finally implement pokemon named tuples (right @cclauss ?) to easily marshal and unmarshal them, not to mention the almost assured speed increase.

I totally support the change @Squirrels

[samuelhnrq]

Some work has been done in #96 that I think can be salvaged

[Squirrels]

Yeah, I'm planning on using that as a base, updating with the new pokemon and information as soon as I'm done with #112 and Mac OS testing for #94 (our current master).

[cclauss]

OK. No more flatfile!