Merge pull request #349 from LeaYeh/fix-sigpipe-leaks

Author: LeaYeh

source/backend/executor/builtin_cmd.c

@@ -87,6 +87,7 @@ static void	exec_builtin_cmd(t_sh *shell)
 {
 	t_fct	*final_cmd_table;
 
+	setup_signal(shell, SIGPIPE, SIG_IGNORE);
 	final_cmd_table = shell->final_cmd_table;
 	if (ft_strcmp(final_cmd_table->simple_cmd[0], "env") == 0)
 		shell->exit_code = exec_env(final_cmd_table->env);
@@ -108,4 +109,5 @@ static void	exec_builtin_cmd(t_sh *shell)
 	else if (ft_strcmp(final_cmd_table->simple_cmd[0], "~") == 0 && \
 			shell->is_interactive)
 		shell->exit_code = exec_easter_egg();
+	setup_signal(shell, SIGPIPE, SIG_STANDARD);
 }

source/backend/executor/external_cmd.c

@@ -61,9 +61,9 @@ static bool	check_execfile_exist(char *exec_path, char *cmd_name)
 static void	reset_external_signal_handler(t_sh *shell)
 {
 	setup_signal(shell, SIGINT, SIG_DEFAULT);
-	setup_signal(shell, SIGQUIT, SIG_DEFAULT);
 	setup_signal(shell, SIGTERM, SIG_DEFAULT);
 	setup_signal(shell, SIGUSR1, SIG_DEFAULT);
+	setup_signal(shell, SIGQUIT, SIG_DEFAULT);
 }
 
 static void	handle_exec_error(t_sh *shell, char *exec_path)

source/backend/executor/simple_cmd_process.c

@@ -44,10 +44,7 @@ static void	exec_simple_cmd(t_sh *shell, t_list_d **cmd_table_node)
 	if (ret == BAD_SUBSTITUTION)
 		shell->exit_code = BAD_SUBSTITUTION;
 	else if (is_builtin(shell->final_cmd_table->simple_cmd[0], shell))
-	{
-		setup_signal(shell, SIGPIPE, SIG_IGNORE);
 		handle_builtin(shell, cmd_table_node);
-	}
 	else
 		handle_external_cmd(shell, get_cmd_table_from_list(*cmd_table_node));
 	clean_and_exit_shell(shell, shell->exit_code, NULL);

source/shell/init.c

@@ -36,8 +36,8 @@ bool	init_shell(t_sh *shell)
 	handle_signal_std(0, NULL, shell);
 	handle_signal_record(0, NULL, shell);
 	setup_signal(shell, SIGINT, SIG_STANDARD);
-	setup_signal(shell, SIGUSR1, SIG_STANDARD);
 	setup_signal(shell, SIGTERM, SIG_STANDARD);
+	setup_signal(shell, SIGUSR1, SIG_STANDARD);
 	setup_signal(shell, SIGQUIT, SIG_IGNORE);
 	return (true);
 }

source/signal/exception_broadcaster.c

@@ -39,8 +39,8 @@ void	raise_error_to_own_subprocess(t_sh *shell, int exit_code, char *msg)
 	if (msg)
 		print_error(STY_RED"%s: error: %s\n"STY_RES, PROGRAM_NAME, msg);
 	setup_signal(shell, SIGINT, SIG_STANDARD);
-	setup_signal(shell, SIGUSR1, SIG_STANDARD);
 	setup_signal(shell, SIGTERM, SIG_STANDARD);
+	setup_signal(shell, SIGUSR1, SIG_STANDARD);
 	setup_signal(shell, SIGQUIT, SIG_IGNORE);
 	signal_to_all_subprocess(shell, SIGTERM);
 	kill(getpid_from_proc(), SIGTERM);