Skip to content

315 phase 4 status report #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

315 phase 4 status report #375

wants to merge 1 commit into from

Conversation

je-lopez
Copy link
Contributor

@je-lopez je-lopez commented Oct 4, 2017

issue: #315

@je-lopez je-lopez mentioned this pull request Oct 4, 2017
Open
jaredatron
jaredatron suggested changes Oct 4, 2017
View reviewed changes
Copy link
Contributor

@jaredatron jaredatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise looks good

backoffice/index.js
})
}


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol you still have changes in this file

web-server/routes/phases.js Outdated
const userId = request.user.id
request.getPhase4UsersWithStatus()
.then(users => {
response.render('users/status', {title: 'Phase 4 Status', users, userId})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this template to 'phases/phase4status'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@jaredatron jaredatron jaredatron requested changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@je-lopez @jaredatron