Skip to content

Commit a23d6a3

Browse files
committed
Merge remote-tracking branch 'origin/main' into fixaccessibilitybug/#499-13-Changing-the-order-of-toolbar-buttons-and-creating-button-groups
2 parents 9dd46a8 + 87b9668 commit a23d6a3

File tree

7 files changed

+33
-19
lines changed

7 files changed

+33
-19
lines changed

src/pods/canvas/canvas.pod.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ export const CanvasPod: React.FC = () => {
233233
}, [modalDialog.isOpen, canvasSchema.selectedElementId]);
234234

235235
return (
236-
<div
236+
<main
237237
className={classes.container}
238238
ref={containerRef}
239239
onScroll={handleScroll}
@@ -282,6 +282,6 @@ export const CanvasPod: React.FC = () => {
282282
/>
283283
)}
284284
</div>
285-
</div>
285+
</main>
286286
);
287287
};

src/pods/canvas/components/canvas-accessible/components/collection-accessible.component.tsx

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,20 +28,24 @@ export const CollectionAccessible: React.FC<Props> = props => {
2828
<>
2929
<h3 ref={collectionRefs.current[table.id]}>
3030
{table.tableName} collection
31-
{!isTabletOrMobileDevice ? (
32-
<>
31+
</h3>
32+
{!isTabletOrMobileDevice ? (
33+
<ul>
34+
<li>
3335
<button type="button" onClick={() => onEditTable(table)}>
3436
Edit {table.tableName} collection
3537
</button>
38+
</li>
39+
<li>
3640
<button
3741
type="button"
3842
onClick={() => onDeleteSelectedItem(table.id)}
3943
>
4044
Delete {table.tableName} collection
4145
</button>
42-
</>
43-
) : null}
44-
</h3>
46+
</li>
47+
</ul>
48+
) : null}
4549
<h4>Fields for {table.tableName} collection</h4>
4650
<FieldList fieldList={table.fields} listName={table.tableName} />
4751
<TableRelationsAccessible

src/pods/canvas/components/canvas-accessible/components/field-accessible.component.tsx

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,18 @@ interface Props {
88
}
99

1010
export const Field: React.FC<Props> = props => {
11-
const { field, listName } = props;
11+
const { field } = props;
1212

1313
const renderNNElement = (NN?: boolean) => {
14-
if (NN) return <span>NN</span>;
14+
if (NN) return <span>Not Null</span>;
15+
};
16+
const renderArrayElement = (isArray?: boolean) => {
17+
if (isArray)
18+
return (
19+
<>
20+
<span>array</span>&nbsp;
21+
</>
22+
);
1523
};
1624

1725
const renderChildrenElement = (name: string, children?: FieldVm[]) => {
@@ -20,9 +28,10 @@ export const Field: React.FC<Props> = props => {
2028
};
2129

2230
return (
23-
<li aria-label={`${listName} field`}>
24-
<span>{field.name}</span>
25-
<span>{field.type}</span>
31+
<li>
32+
<span>{field.name}</span>&nbsp;
33+
<span>{field.type}</span>&nbsp;
34+
{renderArrayElement(field.isArray)}
2635
{renderNNElement(field.isNN)}
2736
{renderChildrenElement(field.name, field.children)}
2837
</li>

src/pods/edit-table/components/field.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,9 @@ interface Props {
3737

3838
const INPUT_NAME = 'Field for field ';
3939
const CHECKBOX_PK = 'Primary key for field ';
40-
const CHECKBOX_FK = 'Checkbox fk for field ';
41-
const CHECKBOX_ARRAY = 'Checkbox isArray for field ';
42-
const CHECKBOX_ISNN = 'Checkbox isNN for field ';
40+
const CHECKBOX_FK = 'Foreign key for field ';
41+
const CHECKBOX_ARRAY = 'Array for field ';
42+
const CHECKBOX_ISNN = 'Not null for field ';
4343
const SELECT = 'Select field type for';
4444
const NESTED_FIELD_ADD_FIELD_LABEL = 'Add nested field for ';
4545

src/pods/edit-table/edit-table.component.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@ export const EditTableComponent: React.FC<Props> = props => {
7171
type="text"
7272
value={table.tableName}
7373
onChange={handleChangeTableName}
74+
onFocus={e => e.currentTarget.select()}
7475
/>
7576
</label>
7677
</div>

src/pods/footer/footer.component.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,11 @@ export const FooterComponent: React.FC = () => {
2929
? getFileNameCanvasIsPristine(filename, NEW_DOCUMENT_NAME)
3030
: getFileNameCanvasDirty(filename, NEW_DOCUMENT_NAME, ASTERISK);
3131
return (
32-
<div className={classes.footerText}>
32+
<footer className={classes.footerText}>
3333
<span>{isDevice ? documentNameMobile() : documentName()}</span>
3434
<button onClick={toggleTheme} className="mobile-only">
3535
{theme.themeMode === 'dark' ? <LightIcon /> : <DarkIcon />}
3636
</button>
37-
</div>
37+
</footer>
3838
);
3939
};

src/pods/toolbar/toolbar.pod.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ import classes from './toolbar.pod.module.css';
2020

2121
export const ToolbarPod: React.FC = () => {
2222
return (
23-
<div className={classes.container}>
23+
<header className={classes.container}>
2424
<ul>
2525
<li>
2626
<NewButton />
@@ -67,6 +67,6 @@ export const ToolbarPod: React.FC = () => {
6767
<ThemeToggleButton darkLabel="Dark Mode" lightLabel="Light Mode" />
6868
</li>
6969
</ul>
70-
</div>
70+
</header>
7171
);
7272
};

0 commit comments

Comments
 (0)