[TEMPORARY] Feature/#513 create dialog import collection #546
Conversation
| JSON.parse(newValue); | ||
| setJsonError(null); | ||
| } catch (error) { | ||
| setJsonError('El JSON no es válido'); |
There was a problem hiding this comment.
OOops, in english the message?
| <div className={classes.jsonTextarea}> | ||
| <label> | ||
| JSON Schema: | ||
| <textarea |
There was a problem hiding this comment.
Let's make the text area to fill the dialog available space
| }; | ||
| onSave(mapEditTableVmToTableVm(newTable)); | ||
| } catch (error) { | ||
| setJsonError('El JSON no es válido'); |
|
|
||
| try { | ||
| JSON.parse(newValue); | ||
| setJsonError(null); |
There was a problem hiding this comment.
One additional case, the JSON maybe valid, but if the user passes an array (e.g. an array with two documents), we should as well treat this as an Error and display a message "Current version only accepts a single document object"
There was a problem hiding this comment.
Let's move this code to business so we can add unit tests
| </div> | ||
| <div className={classes.jsonTextarea}> | ||
| <label> | ||
| JSON Schema: |
There was a problem hiding this comment.
Let's name it: JSON Document
And add on top: Copy here a a document (you can copy it from a collection using a tool like Mongo Compass)
| isCollapsed?: boolean; | ||
| isArray?: boolean; | ||
| isNN?: boolean; | ||
| } |
There was a problem hiding this comment.
Let's move FieldType and FieldVm to the file
edit-table.model.ts
By using this we simplify this file and segregate
No description provided.