Feature/#558 move frequent modeling actions to new floating bar #560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Found something strange when I hover over the buttons, on the add table icon it appears a tooltip "CTRL+C", should it be "Add Table" ? on the Add Relation "CTRL+R" CTRL+C use to be reserved for copy paste On the other hand would it be a good idea to show something like "CTRL+C Add Collection", but maybe not CTRL+C @deletidev what's your take on this? |
|
And maybe now that we have some space on that table, should we add below the icon something like "Add Collection", "Add Relation"? |
…MacOS and action button to show in tooltip ctrl for Windows/Linux, cmd (⌘) for MacOS
…handling to allow certain actions to use single-key shortscuts (add collection, add relation and backspace), update tests with noModifier functionality and ActionButton to show correct tooltip (without Ctrl/Cmd)
…⌘ for Mac, Ctrl for Windows), add test for no-modifier shortcuts tooltip display
…to handle ctrl/cmd, alt and no-modifier cases, update tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move frequent modeling actions to new floating bar (desktop only):
Close #558