Skip to content

Conversation

josenino95
Copy link

If this pull request addresses an open issue on the repository, please add 'Closes #NN' below, where NN is the issue number.

Please briefly summarise the changes made in the pull request, and the reason(s) for making these changes.
I uploaded a new training_attendance.xlsx file that includes a new 'cleaned' tab. We taught this workshop a couple of weeks ago and a common request from learners was to share with them the cleaned version of the data after doing the exercise at the end of episode 2 'Formatting data tables in Spreadsheets'. As some decisions were made to produce this version of the data, I also added some related text at the end of episode 3 under a section called 'A version of the cleaned data'.

If any relevant discussions have taken place elsewhere, please provide links to these.

For more guidance on how to contribute changes to a Carpentries project, please review the Contributing Guide and Code of Conduct.

Please keep in mind that lesson Maintainers are volunteers and it may be some time before they can respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact The Carpentries Team at team@carpentries.org.

Copy link

🆗 Pre-flight checks passed 😃

This pull request has been checked and contains no modified workflow files, spoofing, or invalid commits.

It should be safe to Approve and Run the workflows that need maintainer approval.

@morskyjezek
Copy link
Contributor

Hi @josenino95 - thank you for this contribution and suggestion. I do appreciate the intent to offer a "cleaned" version of the data, which can offer a sort of solution for demonstration. When I have taught this, however, it is really up to the instructor to walk through these and for the learners to work on these on their own. So I'm hesitant to add a pre-formatted and "cleaned" set of the data. It is worth noting that in the similar ecology lesson they specifically have named the data with _messy in the title. If we are going to consider adding a "clean" version, I would suggest this should be a standalone file that is available to learners at the end of the workshop rather than in the initial download.

Copy link
Contributor

@morskyjezek morskyjezek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching and correcting the typo in episode 02 line 196. We will discuss the other changes to the data.

@josenino95
Copy link
Author

Thank you for taking the time to review this @morskyjezek ! I agree with the points you made, specifically that it's better to have the "cleaned" version in a separate file. I debated this when making the contribution, but I thought at that time it was best not to have them download multiple files, as currently the lesson nicely only has them download one file. But if you agree, let's go with having the cleaned version in a separate file. Do you want me to modify my PR or do you want to take care of that change with the file I uploaded?

I understand your hesitation about sharing a cleaned version. I agree that the best pedagogical way to approach this lesson is have learners do the exercise first by their own, and then the instructor talk and show how to clean it. So my contribution is more about making the life of instructors easier, as I've had the experience that learners ask for "the solution" to the exercise, and maybe the instructor doesn't have the time to go over all the cleaning needed and have a version ready to send to learners. I also think that what I added at the end of Ep 3 is a nice discussion about the decisions one has to make when cleaning data, and why when you're doing data entry you have to very clear so it doesn't cause confusion or ambiguity to data users. So any suggestion or modification on that content I added would also be greatly appreciated!

Sorry for the long response, but just wanted to communicate my thought when making the contribution. I'll wait for your response and direction for this PR.

@josenino95
Copy link
Author

Oh, a brief comment adding to the previous one. We could add the cleaned data in a separate file, that doesn't appear in the Setup - Data section at the very beginning, so it wouldn't be a file that learners have to download, but instead just include the link to it in Ep 3 in the section I added. This way learners probably won't look at "the solution" before trying it for themselves.

@josenino95 josenino95 closed this by deleting the head repository Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants