Fix: Improve null safety and error handling in findElementWithCmdURL #481
+31
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
help me to get the proper issue after changing the code |
Contributor
|
Does this fix some actual bug? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the findElementWithCmdURL method to prevent hidden crashes and make error diagnosis easier:
Added null checks for menu, cmdUrl, and PropertyValue[] entries.
Replaced string equality with Objects.equals() for null-safe comparisons.
Improved exception handling:
RuntimeExceptions are logged and rethrown (so critical issues aren’t silently swallowed).
Checked exceptions are logged with context at error level.
Logging improvements: meaningful messages for invalid inputs and unexpected conditions.
These changes ensure that potential null pointer errors won’t bring down LibreOffice silently, and any actual root causes are visible in logs instead of being hidden behind a generic trace statement.