nv cross entropy allow fp16 and none reduction #2446
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liqiangxl
force-pushed
the
llu/cross_entropy
branch
from
f61ec03 to
0e269b6
Compare
for more information, see https://pre-commit.ci
crcrpar
reviewed
Aug 21, 2025
| nv_ignore_index = getnv(ignore_index, fd, lc_to_nv_map) | ||
|
|
||
| zero_scalar = fd.define_scalar(0, dtype=lcdtype_to_nvdtype(a.dtype)) | ||
| if a.dtype in (dtypes.float16, dtypes.bfloat16): |
There was a problem hiding this comment.
nit-picking
Suggested change
| if a.dtype in (dtypes.float16, dtypes.bfloat16): | |
| if requires_cast := a.dtype in (dtypes.float16, dtypes.bfloat16): |
| sum_3 = fd.ops.sum(where_1) | ||
| div = fd.ops.div(sum_3, sum_2_cvt) | ||
|
|
||
| if a.dtype in (dtypes.float16, dtypes.bfloat16): |
There was a problem hiding this comment.
Suggested change
| if a.dtype in (dtypes.float16, dtypes.bfloat16): | |
| if requires_cast: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Extend
nv_cross_entropy_fwd -> cross_entropy_fwdto supportfp16, bfloat16input andnonereduction