Skip to content

Conversation

KaelanDt
Copy link
Collaborator

@KaelanDt KaelanDt commented Oct 13, 2025

What does this PR do?

Fixes the benchmark job, see https://github.com/Lightning-AI/lightning-thunder/pull/2607/files.
Required bumping transformers to run with torch==2.8.0+cu12.8, which fixes #2302 (although still not supporting vmap)

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@@ -1,4 +1,4 @@
transformers==4.52.4
transformers==4.55.4
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This degrades the coverage in the coverage testing (but feel free to do your own requirements.txt if it helps)

@github-actions github-actions bot removed the ci label Oct 14, 2025
@github-actions github-actions bot added the ci label Oct 14, 2025
@KaelanDt KaelanDt force-pushed the kaelan/fix-benchmark branch from 52479af to 9926f62 Compare October 14, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

enable HF transformers 4.43.

2 participants