Enable E712 #2641
Open
Enable E712 #2641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
t-vi
reviewed
Oct 14, 2025
| # with a very negative value that should become ~0 after softmax | ||
| if attn_mask.dtype == torch.bool: | ||
| attn_mask = torch.masked_fill(torch.zeros_like(attn_mask, dtype=query.dtype), attn_mask == False, -math.inf) | ||
| attn_mask = torch.masked_fill(torch.zeros_like(attn_mask, dtype=query.dtype), not attn_mask, -math.inf) |
There was a problem hiding this comment.
Suggested change
| attn_mask = torch.masked_fill(torch.zeros_like(attn_mask, dtype=query.dtype), not attn_mask, -math.inf) | |
| attn_mask = torch.masked_fill(torch.zeros_like(attn_mask, dtype=query.dtype), ~attn_mask, -math.inf) |
To my mind == False is less "line noise" than ~attn_mask and the entire E712 is more than dubious.
There was a problem hiding this comment.
But of course, we can enable it, given that the linters love it.
There was a problem hiding this comment.
I'm not sure about what/how you think so. https://docs.astral.sh/ruff/rules/true-false-comparison/ reads quite reasonable to me
There was a problem hiding this comment.
It also misrepresents pep 8, which literally says
Don’t compare boolean values to True or False using ==:
but the check does
Don’t compare any values to True or False using ==:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As per title.
Related #2218
cc @Borda