Skip to content

After Fintune lora. apply chat_template #1986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HERIUN opened this issue Mar 31, 2025 · 0 comments
Open

After Fintune lora. apply chat_template #1986

HERIUN opened this issue Mar 31, 2025 · 0 comments
Labels
question Further information is requested

Comments

@HERIUN
Copy link

HERIUN commented Mar 31, 2025

Hi. I appreciate your great work.

I fintuned llama-3.2-1B base model using my custom data

litgpt finetune_lora "meta-llama/Llama-3.2-1B" \
 --data JSON \
 --data.json_path /data/donggukang/litgpt/OpenMathInstruct-2-1K_litgpt_format.json \
 --data.val_split_fraction 0.1

The base model repository doesn't have a chat_template defined in its tokenizer_config.json

However, during LoRA fine-tuning, I applied Alpaca template(as a default)

After the LoRA fine-tuning was completed, the prompt_style.yaml file contains the chat template(called in prompt_style), but the tokenizer_config.json still has the same configuration as the base model (i.e., without a chat_template).

Will this cause any issues when loading HF-converted model?
(I think tokenizer_config.json's chat_template must be edited by trained prompt_style..)

@HERIUN HERIUN added the question Further information is requested label Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant