From 6ef4335574fbdee77fde95dee7719dddb4ab9ab2 Mon Sep 17 00:00:00 2001 From: awaelchli Date: Tue, 27 Feb 2024 05:21:30 +0100 Subject: [PATCH] unscale the gradients before gradient clipping in manual optimization --- src/lightning/pytorch/core/module.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/lightning/pytorch/core/module.py b/src/lightning/pytorch/core/module.py index 3075e8952b148..b8b06c38b03e0 100644 --- a/src/lightning/pytorch/core/module.py +++ b/src/lightning/pytorch/core/module.py @@ -1201,6 +1201,7 @@ def clip_gradients( ) gradient_clip_algorithm = GradClipAlgorithmType(gradient_clip_algorithm) + self.trainer.precision_plugin.unscale_gradients(optimizer) self.trainer.precision_plugin.clip_gradients(optimizer, gradient_clip_val, gradient_clip_algorithm) def configure_gradient_clipping(