-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Add save_on_exception
option to ModelCheckpoint
#20916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vsey
wants to merge
49
commits into
Lightning-AI:master
Choose a base branch
from
vsey:feat/ModelCheckpointException
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 28 commits
Commits
Show all changes
49 commits
Select commit
Hold shift + click to select a range
0f73167
add saving of checkpoint if an exception is raised
vsey 136e59a
import callback to checkpoint test file
vsey e0dae53
add test for exception in training callbacks
vsey 2113acc
split test for save checksave point on expection for expetions in tra…
vsey 7d750e6
add extra condition for checking if we should save on exception
vsey 34e598a
add for saving checkpoint on exeption if the exception occurs in a va…
vsey d4d933b
add test for save model chekpoint on exception for exception in train…
vsey 9f6063b
disable trainer prog bar for test of model checkpoint on exception
vsey 02477d5
model checkpoint on eception split trainer setup over two lines
vsey e5b0498
remove trainling braket from shoukd_save_on_eception condition
vsey 8bc93e2
Merge branch 'master' into feat/ModelCheckpointException
vsey 985c1e1
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] f0502ec
Update save checkpoint on exception tests to use a shorter more preci…
vsey 99af7ed
switch default on save on checkpoint on exception to false to don't i…
vsey c092385
checkpoint on exception put callback tests into a pytest prametrization
vsey 904bd74
change doc string to reflect new default value for save on exception …
vsey 3a3204e
checkpoint on exception add test function for exception in callback
vsey 0b1eb77
Merge branch 'master' into feat/ModelCheckpointException
vsey 467c57b
add prefix option to generate checkpoint file name
vsey 8ba6381
add exception prefix to checkpoints saved on exception
vsey 3076ea1
add test to test prefix for checkpoint name
vsey d78ea3e
add test for exceptions at diffrent position in a model
vsey 42bbac1
add description to on exception hook in model checkpoint
vsey c4b8063
add test to check saving on exception in all relevalnt callback posit…
vsey 2ca6dab
also print exception when saving checkpoint
vsey 9e9e580
test checkpointing on exception in varoius model steps
vsey d2f74e9
remove deviders in test_model_checkpoint
vsey ac33670
add test for run conditions for save checkpoint on exception
vsey 0dc9f24
Update model_checkpoint on_exception run condition to follow common c…
vsey 2aa00ad
Merge branch 'master' into feat/ModelCheckpointException
vsey c62f0e1
add checkpoint path variable in test_on_exceptio_incallback and set w…
vsey f16b771
remove exception prefix as this is already covert by last flag
vsey 09ba24f
use pytest parametrization for testing callback on exception
vsey c921875
add missing callback hooks for Test Troubled Callback and order them …
vsey fd3de65
add missing test hooks of lighning module to test save chekpoint on e…
vsey 7dfdbc5
change datatype of on_exception hook from Exception to BaseException …
vsey c2447cb
Merge branch 'Lightning-AI:master' into feat/ModelCheckpointException
vsey f2cd64f
Merge branch 'master' into feat/ModelCheckpointException
vsey 048ad86
change default prefix from empty string to Optinal to better convey m…
vsey 71baa1c
Merge branch 'master' into feat/ModelCheckpointException
vsey e81e291
Merge branch 'master' into feat/ModelCheckpointException
vsey 28c61e1
Merge branch 'master' into feat/ModelCheckpointException
vsey 6b67499
Merge branch 'master' into feat/ModelCheckpointException
vsey 7e990ca
Merge branch 'master' into feat/ModelCheckpointException
vsey f0cf90b
Added save_on_exception option for ModelCheckpoint to changelog
vsey 921c9ee
Fix tense of changelog entrie to be in line with rest of changelog
vsey e388ee7
change changelog entrie tense back
vsey 7c70d46
Merge branch 'master' into feat/ModelCheckpointException
vsey 97900b1
Merge branch 'master' into feat/ModelCheckpointException
vsey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.