Refactor LinearBoostClassifier
to remove sparse data support
#12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
LinearBoostClassifier
to remove support for sparse data by creating a new intermediate base class (_DenseAdaBoostClassifier
) that inherits fromAdaBoostClassifier
.Problem:
The
LinearBoostClassifier
class is inherited fromAdaBoostClassifier
, which supports sparse matrices, butLinearBoostClassifier
itself doesn't support sparse data due to using scalers such asMinMaxScaler
,PowerTransformer
, etc. This created inconsistency in the API documentation where inherited method docstrings suggested sparse matrix support when it wasn't actually available.Solution:
_DenseAdaBoostClassifier
base class that explicitly removes sparse data support_check_X
method in_DenseAdaBoostClassifier
and setaccept_sparse=False
tags.input_tags.sparse = False
in_DenseAdaBoostClassifier
for proper API declarationLinearBoostClassifier
to inherit from the new base classChanges: