Merge pull request #3 from solsglasses/improve_default_sg_output

Improve output default_security_group_id

Author: Sol Rosenberg

data.tf

@@ -1,17 +1,6 @@
 data "aws_availability_zones" "available" {}
 
-data "aws_ami" "ubuntu" {
-  most_recent = true
-
-  filter {
-    name   = "name"
-    values = ["ubuntu/images/hvm-ssd/ubuntu-xenial-16.04-amd64-server-*"]
-  }
-
-  filter {
-    name   = "virtualization-type"
-    values = ["hvm"]
-  }
-
-  owners = ["099720109477"] # Canonical
-}
+data "aws_security_group" "default" {
+  vpc_id = "${aws_vpc.main.id}"
+  name   = "default"
+}

main.tf

@@ -55,7 +55,6 @@ resource "aws_nat_gateway" "main" {
   tags {
     Name = "${trimspace(var.name_tag_prefix)}"
   }
-
 }
 
 resource "aws_route_table" "private" {
@@ -104,24 +103,3 @@ resource "aws_route_table_association" "public" {
   subnet_id      = "${element(aws_subnet.public.*.id, count.index)}"
   route_table_id = "${aws_route_table.public.id}"
 }
-
-resource "aws_default_security_group" "default" {
-# Yes this is created automatically by the aws_vpc resource, however,
-# we have to declare it within terraform to be able to use it as an output
-# for other terraform activities
-  vpc_id = "${aws_vpc.main.id}"
-
-  ingress {
-    from_port = 0
-    to_port   = 0
-    protocol  = "-1"
-    self      = true
-  }
-
-  egress {
-    from_port   = 0
-    to_port     = 0
-    protocol    = "-1"
-    cidr_blocks = ["0.0.0.0/0"]
-  }
-}

outputs.tf

@@ -3,13 +3,13 @@ output "vpc_id" {
 }
 
 output "default_security_group_id" {
-  value = "${aws_default_security_group.default.id}"
+  value = "${data.aws_security_group.default.id}"
 }
 
 locals {
-  empty_list            = ["","","","","","","","","",""]
+  empty_list = ["", "", "", "", "", "", "", "", "", ""]
 
-  private_subnet_padded = "${concat(var.private_subnet_nametags,local.empty_list)}"
+  private_subnet_padded    = "${concat(var.private_subnet_nametags,local.empty_list)}"
   private_subnet_ids_type0 = "${coalescelist(matchkeys(aws_subnet.private.*.id, aws_subnet.private.*.tags.Description,list("${element(local.private_subnet_padded,0)}")),list(""))}"
   private_subnet_ids_type1 = "${coalescelist(matchkeys(aws_subnet.private.*.id, aws_subnet.private.*.tags.Description,list("${element(local.private_subnet_padded,1)}")),list(""))}"
   private_subnet_ids_type2 = "${coalescelist(matchkeys(aws_subnet.private.*.id, aws_subnet.private.*.tags.Description,list("${element(local.private_subnet_padded,2)}")),list(""))}"
@@ -21,7 +21,7 @@ locals {
   private_subnet_ids_type8 = "${coalescelist(matchkeys(aws_subnet.private.*.id, aws_subnet.private.*.tags.Description,list("${element(local.private_subnet_padded,8)}")),list(""))}"
   private_subnet_ids_type9 = "${coalescelist(matchkeys(aws_subnet.private.*.id, aws_subnet.private.*.tags.Description,list("${element(local.private_subnet_padded,9)}")),list(""))}"
 
-  public_subnet_padded = "${concat(var.public_subnet_nametags,local.empty_list)}"
+  public_subnet_padded    = "${concat(var.public_subnet_nametags,local.empty_list)}"
   public_subnet_ids_type0 = "${coalescelist(matchkeys(aws_subnet.public.*.id, aws_subnet.public.*.tags.Description,list("${element(local.public_subnet_padded,0)}")),list(""))}"
   public_subnet_ids_type1 = "${coalescelist(matchkeys(aws_subnet.public.*.id, aws_subnet.public.*.tags.Description,list("${element(local.public_subnet_padded,1)}")),list(""))}"
   public_subnet_ids_type2 = "${coalescelist(matchkeys(aws_subnet.public.*.id, aws_subnet.public.*.tags.Description,list("${element(local.public_subnet_padded,2)}")),list(""))}"
@@ -32,7 +32,6 @@ locals {
   public_subnet_ids_type7 = "${coalescelist(matchkeys(aws_subnet.public.*.id, aws_subnet.public.*.tags.Description,list("${element(local.public_subnet_padded,7)}")),list(""))}"
   public_subnet_ids_type8 = "${coalescelist(matchkeys(aws_subnet.public.*.id, aws_subnet.public.*.tags.Description,list("${element(local.public_subnet_padded,8)}")),list(""))}"
   public_subnet_ids_type9 = "${coalescelist(matchkeys(aws_subnet.public.*.id, aws_subnet.public.*.tags.Description,list("${element(local.public_subnet_padded,9)}")),list(""))}"
-
 }
 
 output "private_subnet_ids" {