Skip to content

Commit ce59ff1

Browse files
committed
All notification plugins are now installed in /usr/lib64/nagios/plugins/notifications/ by default, because otherwise installing the notification and monitoring plugins package at the same time fails (fix #726)
1 parent 86fdd7a commit ce59ff1

File tree

9 files changed

+23
-19
lines changed

9 files changed

+23
-19
lines changed

CHANGELOG.md

+10-6
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,17 @@ Monitoring Plugins:
2222

2323
* disk-io: Nearly rewritten from scratch, old parameters have been replaced by new, better ones. Perfdata "throughput" has been renamed to "bandwidth". Filter disks which are really mounted, translate dm-* device names, wildcard support for ignore disks ([#709](https://github.com/Linuxfabrik/monitoring-plugins/issues/709), [#708](https://github.com/Linuxfabrik/monitoring-plugins/issues/708), [#676](https://github.com/Linuxfabrik/monitoring-plugins/issues/676))
2424
* file-size: Note that the plugin now requires a size qualifier when specifying parameters, e.g. ``--warning=10K`` for 10 KiB (instead of ``--warning=10000`` as in previous versions).
25-
* journald-query: Pattern-matching is now always case-sensitive (fix #745)
25+
* journald-query: Pattern-matching is now always case-sensitive ([#745](https://github.com/Linuxfabrik/monitoring-plugins/issues/745))
2626
* librenms-alerts: Rewritten from scratch to fetch from LibreNMS MySQL/MariaDB database (therefore the check comes with new parameters)
2727
* librenms-health: Rewritten from scratch to fetch from LibreNMS MySQL/MariaDB database (therefore the check comes with new parameters)
2828
* php-fpm: Remove parameters `--*-max-children` because php-fpm `max children reached` is either 0 or 1
2929
* snmp: Improve Performance Data Handling ([#481](https://github.com/Linuxfabrik/monitoring-plugins/issues/481)) - update your CSV definition files and add two more columns according to the check's README
3030
* uptime: Use the plugin to warn about recent reboots ([#722](https://github.com/Linuxfabrik/monitoring-plugins/issues/722)). Note that the plugin now requires a time qualifier when specifying parameters, e.g. ``--warning=180D`` for 180 days (instead of ``--warning=180`` as in previous versions).
3131

32+
Notification Plugins:
33+
34+
* All notification plugins are now installed in `/usr/lib64/nagios/plugins/notifications/` by default, because otherwise installing the notification and monitoring plugins package at the same time fails ([#726](https://github.com/Linuxfabrik/monitoring-plugins/issues/726))
35+
3236

3337
### Added
3438

@@ -48,7 +52,7 @@ Monitoring Plugins:
4852
Icinga Director:
4953

5054
* all-the-rest.json: Rename "Starface Java Status" to "Starface Java Memory Usage"
51-
* all-the-rest: Ignore session-c*.scope in systemd-units-failed by default
55+
* all-the-rest.json: Ignore session-c*.scope in systemd-units-failed by default
5256

5357
Monitoring Plugins:
5458

@@ -693,10 +697,10 @@ Monitoring Plugins:
693697
* all-the-rest.json: add service set for acme.sh ([#447](https://github.com/Linuxfabrik/monitoring-plugins/issues/447))
694698
* all-the-rest.json: Delete SysMain from Windows Service Set ([#446](https://github.com/Linuxfabrik/monitoring-plugins/issues/446))
695699
* all-the-rest.json: fixed guids
696-
* all-the-rest: added acme.sh tag
697-
* all-the-rest: added duplicati service set
698-
* all-the-rest: adjusted loolwsd to coolwsd
699-
* all-the-rest: removed getent from the basic service sets
700+
* all-the-rest.json: added acme.sh tag
701+
* all-the-rest.json: added duplicati service set
702+
* all-the-rest.json: adjusted loolwsd to coolwsd
703+
* all-the-rest.json: removed getent from the basic service sets
700704
* apache-httpd-status: Traceback on Ubuntu Xenial (16.04) ([#436](https://github.com/Linuxfabrik/monitoring-plugins/issues/436))
701705
* basket-join: allowed missing Datafield key
702706
* basket-join: error on duplicate entries in json

assets/icingaweb2-module-director/all-the-rest.json

+5-5
Original file line numberDiff line numberDiff line change
@@ -698,7 +698,7 @@
698698
"value": "$telegram_chat_id$"
699699
}
700700
},
701-
"command": "/usr/lib64/nagios/plugins/notify-host",
701+
"command": "/usr/lib64/nagios/plugins/notifications/notify-host",
702702
"disabled": false,
703703
"fields": [
704704
{
@@ -784,7 +784,7 @@
784784
"value": "$icinga.short_date_time$"
785785
}
786786
},
787-
"command": "/usr/lib64/nagios/plugins/notify-host-mail",
787+
"command": "/usr/lib64/nagios/plugins/notifications/notify-host-mail",
788788
"disabled": false,
789789
"fields": [
790790
{
@@ -865,7 +865,7 @@
865865
"value": "$sms_url$"
866866
}
867867
},
868-
"command": "/usr/lib64/nagios/plugins/notify-host-sms",
868+
"command": "/usr/lib64/nagios/plugins/notifications/notify-host-sms",
869869
"disabled": false,
870870
"fields": [
871871
{
@@ -948,7 +948,7 @@
948948
"value": "$telegram_chat_id$"
949949
}
950950
},
951-
"command": "/usr/lib64/nagios/plugins/notify-service",
951+
"command": "/usr/lib64/nagios/plugins/notifications/notify-service",
952952
"disabled": false,
953953
"fields": [
954954
{
@@ -1040,7 +1040,7 @@
10401040
"value": "$icinga.short_date_time$"
10411041
}
10421042
},
1043-
"command": "/usr/lib64/nagios/plugins/notify-service-mail",
1043+
"command": "/usr/lib64/nagios/plugins/notifications/notify-service-mail",
10441044
"disabled": false,
10451045
"fields": [
10461046
{

notification-plugins/notify-host-mail/icingaweb2-module-director/notify-host-mail.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@
6363
"set_if": "$notify_host_mail_short$"
6464
}
6565
},
66-
"command": "/usr/lib64/nagios/plugins/notify-host-mail",
66+
"command": "/usr/lib64/nagios/plugins/notifications/notify-host-mail",
6767
"disabled": false,
6868
"fields": [
6969
{

notification-plugins/notify-host-rocketchat-telegram/icingaweb2-module-director/notify-host-rocketchat-telegram.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
"value": "$notify_host_rocketchat_telegram_telegram_chat_id$"
4141
}
4242
},
43-
"command": "/usr/lib64/nagios/plugins/notify-host-rocketchat-telegram",
43+
"command": "/usr/lib64/nagios/plugins/notifications/notify-host-rocketchat-telegram",
4444
"disabled": false,
4545
"fields": [
4646
{

notification-plugins/notify-host-zoom/icingaweb2-module-director/notify-host-zoom.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
"value": "$notify_host_zoom_url$"
3434
}
3535
},
36-
"command": "/usr/lib64/nagios/plugins/notify-host-zoom",
36+
"command": "/usr/lib64/nagios/plugins/notifications/notify-host-zoom",
3737
"disabled": false,
3838
"fields": [
3939
{

notification-plugins/notify-service-mail/icingaweb2-module-director/notify-service-mail.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@
6969
"value": "$notify_service_mail_servicename$"
7070
}
7171
},
72-
"command": "/usr/lib64/nagios/plugins/notify-service-mail",
72+
"command": "/usr/lib64/nagios/plugins/notifications/notify-service-mail",
7373
"disabled": false,
7474
"fields": [
7575
{

notification-plugins/notify-service-rocketchat-telegram/icingaweb2-module-director/notify-service-rocketchat-telegram.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
"value": "$notify_service_rocketchat_telegram_telegram_chat_id$"
4444
}
4545
},
46-
"command": "/usr/lib64/nagios/plugins/notify-service-rocketchat-telegram",
46+
"command": "/usr/lib64/nagios/plugins/notifications/notify-service-rocketchat-telegram",
4747
"disabled": false,
4848
"fields": [
4949
{

notification-plugins/notify-service-zoom/icingaweb2-module-director/notify-service-zoom.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
"value": "$notify_service_zoom_url$"
4040
}
4141
},
42-
"command": "/usr/lib64/nagios/plugins/notify-service-zoom",
42+
"command": "/usr/lib64/nagios/plugins/notifications/notify-service-zoom",
4343
"disabled": false,
4444
"fields": [
4545
{

tools/check2basket

+2-2
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ except ImportError:
2424
colorama = False
2525

2626
__author__ = 'Linuxfabrik GmbH, Zurich/Switzerland'
27-
__version__ = '2024031501'
27+
__version__ = '2024052901'
2828

2929
DESCRIPTION = 'A tool to generate Icinga Director baskets from a check plugin.'
3030

@@ -825,7 +825,7 @@ def generate_basket(plugin_file, config=None, old_data=None):
825825
print('Generating "notification-plugin" variant.')
826826
command_object_name = 'cmd-notification-{}'.format(check_name)
827827
notification_object_name = 'tpl-notification-{}'.format(check_name)
828-
command = '/usr/lib64/nagios/plugins/{}'.format(check_name)
828+
command = '/usr/lib64/nagios/plugins/notifications/{}'.format(check_name)
829829
varname_suffix = ''
830830

831831
data = get_command_template(

0 commit comments

Comments
 (0)