Feature/freezer source map support #1743
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merryman
force-pushed
the
feature/freezer-source-map-support
branch
2 times, most recently
from
edc2903 to
a6f6e60
Compare
merryman
force-pushed
the
feature/freezer-source-map-support
branch
from
3d5cb65 to
1485339
Compare
Apparently there is javascript code that manually freezes the classes/prototypes after they have been defined, which makes the in place re-initialization crash. We now add an additional check in the transformed class that avoids running into that conflict.
Previously we would recycle the module url to pkg cache to allow us to retrieve the correct import map, which failed. We now use a dedicated import map cache, that takes care of merging overlapping import maps between different packages.
Parsing would sometimes fail in order to generate the needed ast nodes, due to variables defined outside of the parsed block.
Some of the previous changes caused crashes in the runtime source transform for lively.modules.
Source maps make the prettification unnessecary.
It appears it breaks the source maps on the per module basis.
merryman
force-pushed
the
feature/freezer-source-map-support
branch
from
1485339 to
10a74ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends the source map support from #1710 to also cover frozen bundles. Cannot be merged before.