Skip to content

Conversation

@ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Feb 11, 2025

Description

This PR was intended to start out as adding API authentication, via JWT; however that quickly snowballed into needing many other basic framework features to be put in place such as:

  • config/settings
  • database
  • users

Additionally, since settings were added, settings for the rocket server were added including using TLS with self signed certs.

TODO:

  • database
  • users
  • JWT/API authentication
  • hide secrets in logs

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@codecov
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

❌ Patch coverage is 73.99267% with 71 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.73%. Comparing base (10e0891) to head (c6ce3d4).
⚠️ Report is 25 commits behind head on master.

Files with missing lines Patch % Lines
crates/server/src/auth.rs 49.12% 29 Missing ⚠️
crates/server/src/tray.rs 27.27% 8 Missing ⚠️
crates/server/src/globals.rs 58.82% 7 Missing ⚠️
crates/server/src/web/routes/auth.rs 73.07% 7 Missing ⚠️
crates/server/src/web/routes/user.rs 66.66% 7 Missing ⚠️
crates/server/src/web/mod.rs 86.04% 6 Missing ⚠️
crates/server/tests/test_web/mod.rs 83.33% 4 Missing ⚠️
crates/server/src/db/mod.rs 80.00% 2 Missing ⚠️
crates/server/src/logging/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master       #7       +/-   ##
===========================================
+ Coverage   28.00%   62.73%   +34.73%     
===========================================
  Files          10       18        +8     
  Lines         200      432      +232     
===========================================
+ Hits           56      271      +215     
- Misses        144      161       +17     
Flag Coverage Δ
aarch64-apple-darwin 62.64% <73.62%> (+34.50%) ⬆️
aarch64-unknown-linux-gnu 62.50% <73.62%> (+34.50%) ⬆️
x86_64-apple-darwin 62.64% <73.62%> (+34.50%) ⬆️
x86_64-pc-windows-msvc 62.50% <73.62%> (+34.50%) ⬆️
x86_64-unknown-linux-gnu 62.50% <73.62%> (+34.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
crates/server/src/certs.rs 100.00% <100.00%> (ø)
crates/server/src/config.rs 100.00% <100.00%> (ø)
crates/server/src/db/schema.rs 100.00% <100.00%> (ø)
crates/server/src/dependencies/mod.rs 66.66% <ø> (ø)
crates/server/src/web/routes/common.rs 100.00% <100.00%> (ø)
crates/server/src/web/routes/dependencies.rs 60.00% <100.00%> (ø)
crates/server/src/web/routes/mod.rs 100.00% <100.00%> (ø)
crates/server/tests/fixtures/mod.rs 100.00% <100.00%> (ø)
crates/server/tests/test_dependencies/mod.rs 100.00% <100.00%> (ø)
crates/server/src/logging/mod.rs 0.00% <0.00%> (ø)
... and 8 more

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ReenigneArcher ReenigneArcher force-pushed the feat/more-framework branch 17 times, most recently from 00c9381 to 256039a Compare February 23, 2025 15:51
@ReenigneArcher ReenigneArcher force-pushed the feat/more-framework branch 2 times, most recently from 1312691 to ef3ef2a Compare March 14, 2025 00:41
@ReenigneArcher ReenigneArcher force-pushed the feat/more-framework branch 9 times, most recently from 6001bb9 to 20d425d Compare March 22, 2025 20:52
@ReenigneArcher ReenigneArcher force-pushed the feat/more-framework branch 4 times, most recently from 5ab65ae to cc0f60d Compare May 7, 2025 20:02
@ReenigneArcher ReenigneArcher force-pushed the feat/more-framework branch 8 times, most recently from 710a1e2 to 29d29a4 Compare June 15, 2025 01:35
@sonarqubecloud
Copy link

@ReenigneArcher ReenigneArcher marked this pull request as ready for review July 16, 2025 03:13
@ReenigneArcher
Copy link
Member Author

I'm going to merge and work on improvements later.

@ReenigneArcher ReenigneArcher merged commit 5041b2a into master Jul 16, 2025
17 checks passed
@ReenigneArcher ReenigneArcher deleted the feat/more-framework branch July 16, 2025 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants