Skip to content

Update the nCine addons submodule #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

encelo
Copy link
Contributor

@encelo encelo commented Dec 3, 2024

I have updated the nCine submodule commit to point to the latest one where I have removed the trailing commas from config.json and .luarc.json.

Update: I have rebased this branch on top of the latest C.I. fixes.

@carsakiller
Copy link
Collaborator

carsakiller commented Dec 3, 2024

I believe it was trying to push to the wrong branch… or perhaps it is not considered a maintainer and thus doesn't have permission to edit the PR… let's give it a try. @encelo, could you rebase on main to get the latest workflow file?

@encelo encelo closed this Dec 4, 2024
@encelo encelo deleted the update-ncine branch December 4, 2024 00:22
@encelo encelo restored the update-ncine branch December 4, 2024 00:23
@encelo
Copy link
Contributor Author

encelo commented Dec 4, 2024

I have opened PR #199.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants