-
Notifications
You must be signed in to change notification settings - Fork 4
Markdown-toc fails if there are multiple .md files #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I opened jonschlinkert/markdown-toc#162 to suggest the evolution in |
Awesome! I was checking in the upstream issues to see if someone already asked for this before creating a new one but you beat me to it ^^ |
would be helpful to have it now have to use multiple hooks for each file: - repo: https://github.com/Lucas-C/pre-commit-hooks-nodejs
rev: v1.1.1
hooks:
- id: markdown-toc
name: README.md-toc
files: ^README\.md$
- id: markdown-toc
name: configuration.md-toc
files: .*/configuration\.md$
- id: markdown-toc
name: CONTRIBUTE.md-toc
files: .*/CONTRIBUTE\.md$ |
This depend on jonschlinkert/markdown-toc#162 |
@Lucas-C would you like to create a PR for this? |
What do we need to fix this? |
Have this PR merged: jonschlinkert/markdown-toc#172 |
How much longer to wait until we just switch to your fork of the repo? |
+1 on switching the fork until they merge |
I released a This issue should be solved now |
Thanks @Lucas-C! |
After #4 landed the precommit fails if multiple Markdown files are present, because
markdown-toc
doesn't support multiple input files on its CLI. This is sad because it was the point of that PR 😅This issue has been reported by Yajo itself here pre-commit/pre-commit#1374
My current workaround is to use the pre-commit offered by DocToc (as mentioned in the pre-commit issue).
Note: This issue is more of a heads-up for others who would run into the same problem because it would need to be fixed in the
markdown-toc
project directly.The text was updated successfully, but these errors were encountered: