Skip to content

Removed on tick handler, GUI update bug was fixed in 2.0 #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Removed on tick handler, GUI update bug was fixed in 2.0 #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions control.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -640,18 +640,5 @@ script.on_event(defines.events.on_gui_click, function(event)
end
end)

-- we need to close the ui on click and open it a tick later
-- to visually update the filter ui
-- if https://forums.factorio.com/viewtopic.php?f=7&t=106300 gets addressed,
-- this close/reopen GUI business can be removed
script.on_event(defines.events.on_tick, function(event)
for _, player in pairs(game.players) do
local player_global = get_player_global(player.index)
if player_global then
update_ui(player_global, event.tick % 60 == 0)
end
end
end)

-- TODO options for what things are considered. Chests, transport lines, etc
-- TODO recently used section