Adding API for NORAC and NORA3 wave spectra timeseries #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e as either xarray/netcdf or csv
KonstantinChri
approved these changes
Oct 22, 2024
lassebje
reviewed
Oct 23, 2024
| url = get_url_info(ts.product, dates[i]) | ||
|
|
||
| if i == 0: | ||
| station, lon_near, lat_near = get_near_coord( |
There was a problem hiding this comment.
@efvik: lon_near and lat_near are not used in the csv-file but rather ds["longitude"][0].values). This breaks the pattern of the other output a bit. Perhaps a comment should be added here to explain why the first coordinate is used instead of the station coordinate
There was a problem hiding this comment.
ds["longitude"][0].values should be equal to lon_near when the correct station has been selected, but we can use lon_near and lat_near since it is clearer.
In investigating this I found an issue with the indexing of stations, which are one-indexed. I fixed this by adding 1 to the station number in aux_funcs. See PR #40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New products added, including tests:
I implemented the option of saving spectra to .csv in a "panel" data format, although it is very inefficient compared to using NetCDF .nc files due to the multidimensional spectra data.