Skip to content

Commit 7c579a6

Browse files
authored
correcting dependency issues in ugandaemr reports (#370)
1 parent d285d9d commit 7c579a6

File tree

2 files changed

+24
-38
lines changed

2 files changed

+24
-38
lines changed

api/src/main/resources/moduleApplicationContext.xml

Lines changed: 23 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -9,44 +9,30 @@
99

1010
<!-- Add here beans related to the API context -->
1111
<context:component-scan base-package="org.openmrs.module.ugandaemrreports" />
12-
<bean id="ugandaemrreports.reportService" parent="serviceContext">
12+
13+
<bean id="ugandaemrreports.UgandaEMRReportsService"
14+
class="org.springframework.transaction.interceptor.TransactionProxyFactoryBean">
15+
<property name="transactionManager">
16+
<ref bean="transactionManager" />
17+
</property>
18+
<property name="target">
19+
<bean class="org.openmrs.module.ugandaemrreports.api.impl.UgandaEMRReportsServiceImpl">
20+
<property name="dao" ref="ugandaemrreports.HibernateUgandaEMRReportsDAO" />
21+
</bean>
22+
</property>
23+
<property name="preInterceptors">
24+
<ref bean="serviceInterceptors" />
25+
</property>
26+
<property name="transactionAttributeSource">
27+
<ref bean="transactionAttributeSource" />
28+
</property>
29+
</bean>
30+
31+
<bean parent="serviceContext">
1332
<property name="moduleService">
14-
<list merge="true">
15-
<value>org.openmrs.module.reportingcompatibility.service.ReportService</value>
16-
<bean class="org.springframework.transaction.interceptor.TransactionProxyFactoryBean">
17-
<property name="transactionManager"><ref bean="transactionManager"/></property>
18-
<property name="target">
19-
<bean class="org.openmrs.report.impl.ReportServiceImpl">
20-
<property name="reportDAO">
21-
<bean class="org.openmrs.report.db.hibernate.HibernateReportDAO">
22-
<property name="sessionFactory"><ref bean="sessionFactory"/></property>
23-
</bean>
24-
</property>
25-
<property name="renderers">
26-
<map>
27-
<entry>
28-
<key><value>org.openmrs.web.report.CohortReportWebRenderer</value></key>
29-
<bean class="org.openmrs.web.report.CohortReportWebRenderer"/>
30-
</entry>
31-
<entry>
32-
<key><value>org.openmrs.report.impl.TsvReportRenderer</value></key>
33-
<bean class="org.openmrs.report.impl.TsvReportRenderer"/>
34-
</entry>
35-
<entry>
36-
<key><value>org.openmrs.report.impl.CsvReportRenderer</value></key>
37-
<bean class="org.openmrs.report.impl.CsvReportRenderer"/>
38-
</entry>
39-
</map>
40-
</property>
41-
</bean>
42-
</property>
43-
<property name="preInterceptors">
44-
<ref bean="serviceInterceptors" />
45-
</property>
46-
<property name="transactionAttributeSource">
47-
<bean class="org.springframework.transaction.annotation.AnnotationTransactionAttributeSource"/>
48-
</property>
49-
</bean>
33+
<list>
34+
<value>org.openmrs.module.ugandaemrreports.api.UgandaEMRReportsService</value>
35+
<ref bean="ugandaemrreports.UgandaEMRReportsService" />
5036
</list>
5137
</property>
5238
</bean>

omod/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@
110110
<groupId>org.openmrs.module</groupId>
111111
<artifactId>reportingcompatibility-api</artifactId>
112112
<version>${reportingCompatibilityVersion}</version>
113-
<scope>compile</scope>
113+
<scope>provided</scope>
114114
</dependency>
115115

116116
</dependencies>

0 commit comments

Comments
 (0)