U4X-883 :Sync Requisition of Stock from UgandaEMR to eAFYA #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slubwama
requested review from
akileng56 and
dbaluku
and removed request for
dbaluku
…dule-ugandaemr-sync into U4X-883 # Conflicts: # api/src/main/java/org/openmrs/module/ugandaemrsync/server/SyncFHIRRecord.java # api/src/main/resources/liquibase.xml
akileng56
requested changes
Mar 20, 2025
api/src/main/resources/liquibase.xml
Outdated
| <column name="repeat_interval" value="3600" /> | ||
| <column name="date_created" valueDate="CURRENT_TIMESTAMP" /> | ||
| <column name="created_by" value="1" /> | ||
| <column name="start_on_startup" value="1"/> |
There was a problem hiding this comment.
I think this should not be started by default, Not every facility will need it
There was a problem hiding this comment.
@akileng56 resolved.
api/src/main/resources/liquibase.xml
Outdated
| <column name="repeat_interval" value="3600" /> | ||
| <column name="date_created" valueDate="CURRENT_TIMESTAMP" /> | ||
| <column name="created_by" value="1" /> | ||
| <column name="start_on_startup" value="1"/> |
There was a problem hiding this comment.
Same here, Not started by default
There was a problem hiding this comment.
@akileng56 resolved
api/src/main/resources/liquibase.xml
Outdated
| <comment>Sync Task Type</comment> | ||
| <insert tableName="sync_task_type"> | ||
| <column name="name" value="eAFYA Stock Integration"/> | ||
| <column name="data_type" value="org.openmrs.TestOrder" /> |
There was a problem hiding this comment.
TestOrder? why not DrugOrder
There was a problem hiding this comment.
@akileng56 resolved
pom.xml
Outdated
| <fhir2ModuleVersion>2.3.0</fhir2ModuleVersion> | ||
| <webservices.restModuleVersion>2.47.0</webservices.restModuleVersion> | ||
| <ibatisVersion>3.0</ibatisVersion> | ||
| <stockmanagementVersion>1.4.2</stockmanagementVersion> |
There was a problem hiding this comment.
Is this the version before or After the change that was made in stock mgt?
There was a problem hiding this comment.
@akileng56 rresloved
akileng56
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://metsprogramme.atlassian.net/browse/U4X-883
https://metsprogramme.atlassian.net/browse/U4X-884