please add Argon2

[RDP1974]

please add Argon2
it's the default now

[MHumm]

If somebody helps implementing this, things will get worked out quicker.

...my next planned hash target would have been SHA3. But that can take time as I got stuck
a bit on adapting an existing Pascal version I have.

Another thing regarding Argon2: it is internally based on blake2 and that one is based
on ChaCha internally. So it might be good to get those implemented first...

[RDP1974]

https://github.com/JackTrapper/argon2-for-delphi
maybe this can be ok, I will check the quality of the code

[jaclas]

https://github.com/JackTrapper/argon2-for-delphi
maybe this can be ok, I will check the quality of the code

Warning: This implementation is incomplete. There are items in the Argon2 specification that are undocumented.

[MHumm]

I would welcome contributions if they fit and the quality is ok.
Some points to note:

1. Such new classes (Aragon2 has several variants and they inherit from a common base as the code referenced shows) should inherit from the otherwise still unused TPasswordHash class.
2. Everything which is of more common nature (means: doesn't strictly belong to Aragon2) should go in that parent class if possible so other classes can benefit from this
3. The Base64 stuff contained in there should be replaced with the Base64 implementation from DECFormats if possible
4. Unit tests should be submitted as well. At least 2-3 test vectors per algorithm.
5. I wouldn't mind if for the start only those variants which look ok in the referenced code are contributed
6. It might be good to contribute stuff stepwise so I don't get lost when reviewing and integrating this. Bear in mind that my Git knowledge is still rough...
7. Code should be properly XMLDOC commented and those long comments in the referenced code should be looked at. Some might be candidates for removal and many others are candidates for formatting them more compact.
8. Code must of course be adapted in such a way that it meets the general current interface of DEC. We might need to talk about how to specify these additional parameters the algorithm has, but in doubt for a first start make constants out of them until we got everything working again and then we decide how to do it or suggest a way.

So if you try to follow these points fire up your IDE and start to adapt that referenced code! I'd be happy if we can get it into some fitting form...

[MHumm]

Has any work about that already started?

[ralf3i]

Is there any news on that?

[MHumm]

Unfortunatelly no. My time is somewhat limited at the moment and before adding further algorithms I need to work out how a certain architecture problem in DEC should get fixed (means how the API should look like as the current one can produce wrong results in some cases) and then work out the actual fix.

[MHumm]

https://github.com/JackTrapper/argon2-for-delphi
maybe this can be ok, I will check the quality of the code

Warning: This implementation is incomplete. There are items in the Argon2 specification that are undocumented.

Why are there undocumented items in that specification?
Are there maybe "levels" of implementations?
Or has it to do with patents?
Or how to implement undocumented specification parts?
Is original (means from the inventors of the algorithms or from a standardisation body) test data available?

[jaclas]

https://github.com/JackTrapper/argon2-for-delphi
maybe this can be ok, I will check the quality of the code

Warning: This implementation is incomplete. There are items in the Argon2 specification that are undocumented.

Why are there undocumented items in that specification? Are there maybe "levels" of implementations? Or has it to do with patents? Or how to implement undocumented specification parts? Is original (means from the inventors of the algorithms or from a standardisation body) test data available?

Did you read what they wrote in the repo?

[MHumm]

I did now, thanks for pointing out, but: they only point to a draft for an RFC. The current status is this RFC as it seems, which contains an erratum:

https://www.rfc-editor.org/rfc/inline-errata/rfc9106.html#btn_7721

I haven't read the complete RFC, but where do I find information what's incomplete?

[jaclas]

I don't know, unfortunately I can't help. I abandoned Delphi a few years ago and work in other technologies/languages, my post you refer to is 4 years old.

[MHumm]

Ok!