fix: Update dependency fft-conv-pytorch to torch-fftconv #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello all!
With nnUNet, we currently receive the following warning using PyTorch 2.9:
The source of this is from
fft-conv-pytorchwhich is a dependency ofbatchgeneratorsv2. Unfortunately, it does not look likefft-conv-pytorchis being maintained. This PR has existed since July: fkodom/fft-conv-pytorch#26The offending code:
fft-conv-pytorch/fft_conv_pytorch/fft_conv.pylines 134-139`With the help of a coworker, we found an active fork with PyPi releases where someone did fix the issue:
The fix:
fft-conv-pytorch/torch_fftconv/functional.pylines 242-245I have updated and tested the two locations where this library is used in
batchgeneratorsv2and updated thepyproject.tomlto replace the out of date dependency.