Remove encoding unlimited_dims if Time not present #662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should hopefully fix an issue with the `Time` dimension.
When xarray 2025.08.0 opens a file with an empty unlimited Time dimension but no variables with Time, it drops `Time` as a dimension but keeps it in `unlimited_dims`. This is probably not an expected behavior but it's easy enough to address by setting `unlimited_dims = None` if `Time` is not present.
|
This issue was caught by CI, so having CI passing will be the the test to make sure this is fixed. But I will also run Polaris workflows with a test build of mpas_tools 1.3.0 before making the release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When xarray 2025.08.0 (released recently) opens a file with an empty unlimited Time dimension but no variables with Time, it drops
Timeas a dimension but keeps it inunlimited_dims. This is probably not an expected behavior but it's easy enough to address by settingunlimited_dims = NoneifTimeis not present.This merge also switches
sort_meshto usewrite_netcdf()to avoid this issue. A--formatargument has been added that defaults toNETCDF4, which was previously the hard-coded format.