Support ISMIP6 Forcing Generation for Greenland #853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewdnolan
added
land ice
in progress
andrewdnolan
force-pushed
the
ismip6_GrIS_forcing
branch
from
1af8739 to
deb7587
Compare
Ensure's the climatology can be found by multiple steps, in order process the SMB anomoly files provided by ISMIP6.
- Now packing atm/ocn forcing vars into their own respective forcing files - moved shared utilites to common file - fixed bug in returning conctenated atm files from file finder
andrewdnolan
force-pushed
the
ismip6_GrIS_forcing
branch
from
deb7587 to
08c38df
Compare
Made all variables snake case. Add docstings to all functions, methods, and classes.
andrewdnolan
removed
in progress
Collaborator
Author
|
Based on offline discussion, I don't actually think this needs a MALI PR. The elevation dependent components of the the forcing (i.e. |
andrewdnolan
commented
Nov 8, 2025
Comment on lines
+57
to
+59
| # need a special way to treat the RACMO datasets | ||
| if expr_name in ["ctrl", "hist"]: | ||
| continue |
Collaborator
Author
There was a problem hiding this comment.
@trhille @matthewhoffman Now I'm remembering what stalled this PR originally.
What should we do about atm/ocn data during a historical run? Should we do a different historical run for each GCM? I think I recall ISMIP6 cautioning against that.
https://theghub.org/groups/ismip6/wiki/ISMIP6-Projections-Greenland
The unforced control run should be easy to support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to enable ISMIP6 forcing file generation for the Greenland Ice Sheet.
Checklist
api.rst) has any new or modified class, method and/or functions listedE3SM-Projectsubmodule has been updated with relevant E3SM changesMALI-Devsubmodule has been updated with relevant MALI changesTestingin this PR) any testing that was used to verify the changes