feature warnings to errors

Author: podborski

conformance-search/src/types/json.ts

@@ -1,14 +1,21 @@
 export type Coverage = {
+    not_found: {
+        count: number;
+        percentage: number;
+        boxes: string[];
+        missing_extensions: string[];
+        paths: string[];
+    };
     lists: {
         boxes: {
-            covered: Array<string>;
-            not_covered: Array<string>;
-            under_consideration: Array<string>;
+            covered: string[];
+            not_covered: string[];
+            under_consideration: string[];
         };
         features: {
-            covered: Array<string>;
-            not_covered: Array<string>;
-            under_consideration: Array<string>;
+            covered: string[];
+            not_covered: string[];
+            under_consideration: string[];
         };
     };
     path_file_map: {
@@ -28,8 +35,6 @@ export type Coverage = {
         count: number;
         published_features: number;
         under_consideration_features: number;
-        features_from_spec: number;
-        features_from_file: number;
     };
     files: {
         count: number;
@@ -39,15 +44,16 @@ export type Coverage = {
     boxes: {
         count: number;
     };
-    spec_info: Array<{
+    spec_info: {
         ISO: string;
         name: string;
         version: number;
         date: number;
+        mp4ra_reference: string[];
         link: string;
-        amendmends?: Array<string>;
-        corrigenda?: Array<string>;
-    }>;
+        amendmends?: string[];
+        corrigenda?: string[];
+    }[];
 };
 
 export type FileMetadata = {
@@ -65,8 +71,8 @@ export type FileMetadata = {
     conforms_to: {
         ISO: string;
         version: number;
-        amendmends?: Array<string>;
-        corrigenda?: Array<string>;
+        amendmends?: string[];
+        corrigenda?: string[];
     }[];
     notes:
         | string
@@ -79,7 +85,6 @@ export type FeatureFileMap = {
     key: string;
     description: string;
     spec: string;
-    added_from_file: "spec" | "file";
     files: string[];
 };
 

src/construct/coverage.py

@@ -57,8 +57,6 @@ def main():
             "count": "Total number of features",
             "published_features": "Number of features that has published files",
             "under_consideration_features": "Number of features that exclusively has under consideration files",
-            "features_from_spec": "Number of features that are from the spec",
-            "features_from_file": "Number of features that are added from files because they were not found in the spec",
         },
         "files": {
             "count": "Number of files that were submitted",
@@ -215,12 +213,6 @@ def main():
                 and all(["under_consideration" in p for p in f["files"]])
             ]
         ),
-        "features_from_spec": len(
-            [f for f in files["feature_file_map"].values() if f["source"] == "spec"]
-        ),
-        "features_from_file": len(
-            [f for f in files["feature_file_map"].values() if f["source"] == "file"]
-        ),
     }
 
     LISTS = {

src/construct/dictionary.py

@@ -22,9 +22,6 @@ def main():
 
     # In case we missed some specs
     for feature in files["feature_file_map"].values():
-        # FIXME: This shouldn't be necessary
-        if feature["spec"] == "N/A":
-            continue
         specs.add(feature["spec"])
 
     # Sort the sets

src/construct/files.py

@@ -213,7 +213,6 @@ def main():
                         "key": key,
                         "description": value,
                         "spec": spec,
-                        "source": "spec",
                         "files": [],
                     }
                 else:
@@ -225,17 +224,9 @@ def main():
             if feature in feature_file_map:
                 feature_file_map[feature]["files"].append(path)
             else:
-                # FIXME: This should be an error
-                logger.warning(
-                    f'Feature "{feature}" not found in user_defined.json. Adding a empty entry for now.'
+                logger.error(
+                    f'Feature "{feature}" not found in standard features. File: {path}'
                 )
-                feature_file_map[feature] = {
-                    "key": feature,
-                    "description": "N/A",
-                    "spec": "N/A",
-                    "source": "file",
-                    "files": [path],
-                }
 
     # Sort files
     for key, value in feature_file_map.items():