Skip to content

Conversation

kkappler
Copy link
Collaborator

Description

"numpy>=1.24,<2"
in setup.py.

1.24 is the highest version that is compatible with python 3.8

Motivation and Context

When installing from git clone and then pip, which looks at setup.py, the lack of a pinned version was allowing numpy>2. This is still a problem with simpeg, so to work around it we pin numpy <2.

How Has This Been Tested?

Run the tests in mtpy-v2
Run the tests in aurora (which pip install mtpy-v2 from github)

Screenshots (if appropriate):

Types of changes

  • [X ] Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.66%. Comparing base (797a922) to head (7c1a29a).
Report is 3 commits behind head on updates.

Additional details and impacted files
@@           Coverage Diff            @@
##           updates      #62   +/-   ##
========================================
  Coverage    33.66%   33.66%           
========================================
  Files          146      146           
  Lines        24144    24144           
========================================
  Hits          8129     8129           
  Misses       16015    16015           
Flag Coverage Δ
tests 33.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kkappler kkappler requested a review from kujaku11 October 14, 2024 19:32
@kkappler kkappler marked this pull request as ready for review October 14, 2024 19:33
@kkappler kkappler merged commit 8038685 into updates Oct 14, 2024
10 checks passed
@kkappler kkappler deleted the pin_numpy branch October 14, 2024 19:33
@Patrick-Cole
Copy link

Is there any plan to relax this requirement? My numpy is greater than 2 and I would like to use mtpy-v2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants