Skip to content

Conversation

@MVRU
Copy link
Owner

@MVRU MVRU commented Oct 2, 2025

🚀 Pull Request – Conectando Corazones

Resumen del cambio

Corregir el sign-in según DER y documentación


📝 Checklist

  • Alineado al DER y contratos de datos (types, mocks, DTOs).
  • Documentación y mocks actualizados si aplica.
  • El código sigue los lineamientos generales del proyecto.
  • Pasan los tests existentes y los nuevos.
  • Estoy de acuerdo con seguir el Código de Conducta al enviar este PR.
  • He leido la Guía para Contribuir al proyecto.

🧪 Pruebas realizadas

Detallá qué hiciste para validar que funciona y no rompe nada.
Ej.: formulario de registro probado con casos válidos/invalidos.

📸 Capturas (opcional)

Si hiciste un cambio visual, agregá una imagen o GIF.

… URL input

- Implemented FotoPerfilUploader.svelte to handle image uploads via file input or URL.
- Integrated FotoPerfilUploader into InstitucionForm.svelte for user profile picture management.
- Updated form validation to include checks for uploaded images and URLs.
- Added utility function enfocarPrimerCampoConError to focus on the first error field during form submission.
@vercel
Copy link

vercel bot commented Oct 2, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
conectando-corazones Ready Ready Preview Comment Nov 8, 2025 7:19pm

@MVRU MVRU self-assigned this Oct 2, 2025
@MVRU MVRU marked this pull request as draft October 2, 2025 23:14
- Added mappers for Usuario, Colaborador, and Institucion to standardize data extraction from Firestore.
- Introduced utility functions for data sanitization and validation.
- Created a new store for authentication with comprehensive user profile management.
- Implemented tests for authentication actions and user profile updates.
- Removed deprecated info file and updated type definitions for Firebase environment variables.
- Enhanced Vitest configuration to mock Firebase services for testing.
…nhancing validation consistency and enabling unit testing
AleSklate0807
AleSklate0807 previously approved these changes Oct 24, 2025
@MVRU MVRU requested a review from AleSklate0807 October 24, 2025 14:15
…es in total steps and improve form validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants