Open
Conversation
Enable the pyupgrade (`UP`) rule and apply all autofixes. Refs MaartenGr#2450
…otation The `pipeline` (lowercase) is a factory function from transformers, not a type. PEP 604 `str | pipeline` crashes at runtime on Python 3.10+ because the `|` operator requires both operands to be actual types. `Pipeline` (uppercase, from transformers.pipelines.base) is the correct class type. Same class of bug as the `str | callable` fix — mechanical pyupgrade conversion exposing latent type annotation errors. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Author
|
Hi @MaartenGr — CI is fully green across Python 3.10–3.13. Let me know if you'd like any changes or have questions about the approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Discussion at #2450
Enable the pyupgrade (
UP) ruff rule and fix all existing violations.The main changes are:
list,dict,tupleinstead ofList,Dict,Tuple):X | Yinstead ofUnion[X, Y]):super(), f-strings instead of%/.format(), remove redundantopen()modes, remove uselessobjectinheritance.All safe for Python >=3.10 (project minimum). Follows the same pattern as #2457 (RUF) and #2461 (PD).
Summary:
Refs #2450
Before submitting