ToricHigherDirectImages for JSAG #4000
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yay -- pull request #4000!!!! 🎉 🥳 |
antonleykin
reviewed
Oct 22, 2025
| -- types | ||
| -- methods | ||
| "frobeniusPushforward", | ||
| "frobeniusDirectImage", |
There was a problem hiding this comment.
A cleaner way to declare a synonym would be to write
"frobeniusDirectImage" => "frobeniusPushforward"
(on line 38) and then get rid of anythin that mentions frobeniusDirectImage in the rest of code and documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR for the review process of ToricHigherDirectImages for JSAG.
Since I had the chance to make some minor changes, I changed
frobeniusDirectImagetofrobeniusPushforward, but added it as a synonym (hopefully this means I don't need to revise the paper..?).The original PR for the package is at #3720.
Other related PRs fixing minor bugs are: #3729, #3757, #3823, and #3884.