-
Notifications
You must be signed in to change notification settings - Fork 1
Added Songs model, other minor fixes #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
navbar_title = _('Photos') | ||
multipart = True | ||
form_class = forms.PhotoForm | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed navbar_title as db0 mentioned in PR #25
|
||
weight = models.PositiveIntegerField(_('Weight'), null=True) | ||
weight = models.PositiveIntegerField(_('Weight (kg)'), null=True) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added height/weight measurement units for clarity
i_how_to_obtain = models.PositiveIntegerField(_('How to obtain'), choices=i_choices(HOW_TO_OBTAIN_CHOICES), db_index=True) | ||
#@TODO expand this section to link photos to specific photo sets and events | ||
''' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WIP. Do we want a photoshoot vs event card distinction or just to link to a specific photo set / event?
|
||
i_color = models.PositiveIntegerField(_('Color'), choices=i_choices(COLOR_CHOICES), db_index=True) | ||
i_color = models.PositiveIntegerField(_('Attribute (Color)'), choices=i_choices(COLOR_CHOICES), db_index=True) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed Colors to display as Attributes. Can be reverted if database just stores them as their color names.
sub_skill_percentage = models.FloatField('Sub skill percentage', null=True) | ||
# Currently either 3k (gacha URs) or 2k (All other cards) | ||
sub_skill_increment = models.PositiveIntegerField(_('Sub skill level up increment'), null=True) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed field title names
return Photo.LEADER_SKILL_INFO['template'].format(**_leader_skill_variables) | ||
|
||
CROWN_OPTIONS = [150, 200] #Now only 200; change this to a variable | ||
CROWN_OPTIONS = [200] #Now only 200; change this to a variable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should maybe change this to a variable; tempted to leave it as a list in case other amounts are added in the future.
pro_difficulty = models.PositiveIntegerField(string_concat('PRO', ' - ', _('Difficulty')), validators=DIFFICULTY_VALIDATORS, null=True) | ||
master_notes = models.PositiveIntegerField(string_concat('MASTER', ' - ', _('Notes')), null=True) | ||
master_difficulty = models.PositiveIntegerField(string_concat('MASTER', ' - ', _('Difficulty')), validators=DIFFICULTY_VALIDATORS, null=True) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Song model (WIP). Still need to implement associated idols & song type (normal/campaign/event).
Songs tab is here!
Comments for smaller changes added in-line.