Skip to content

Conversation

AlexaDeGrandmont
Copy link

Songs tab is here!

  • Not sure of best way to select/associate idols when entering a song.
  • Not sure how we want to split songs into categories (Normal vs Campaign vs Event?)
    Comments for smaller changes added in-line.

navbar_title = _('Photos')
multipart = True
form_class = forms.PhotoForm

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed navbar_title as db0 mentioned in PR #25


weight = models.PositiveIntegerField(_('Weight'), null=True)
weight = models.PositiveIntegerField(_('Weight (kg)'), null=True)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added height/weight measurement units for clarity

i_how_to_obtain = models.PositiveIntegerField(_('How to obtain'), choices=i_choices(HOW_TO_OBTAIN_CHOICES), db_index=True)
#@TODO expand this section to link photos to specific photo sets and events
'''
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WIP. Do we want a photoshoot vs event card distinction or just to link to a specific photo set / event?


i_color = models.PositiveIntegerField(_('Color'), choices=i_choices(COLOR_CHOICES), db_index=True)
i_color = models.PositiveIntegerField(_('Attribute (Color)'), choices=i_choices(COLOR_CHOICES), db_index=True)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed Colors to display as Attributes. Can be reverted if database just stores them as their color names.

sub_skill_percentage = models.FloatField('Sub skill percentage', null=True)
# Currently either 3k (gacha URs) or 2k (All other cards)
sub_skill_increment = models.PositiveIntegerField(_('Sub skill level up increment'), null=True)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed field title names

return Photo.LEADER_SKILL_INFO['template'].format(**_leader_skill_variables)

CROWN_OPTIONS = [150, 200] #Now only 200; change this to a variable
CROWN_OPTIONS = [200] #Now only 200; change this to a variable
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should maybe change this to a variable; tempted to leave it as a list in case other amounts are added in the future.

pro_difficulty = models.PositiveIntegerField(string_concat('PRO', ' - ', _('Difficulty')), validators=DIFFICULTY_VALIDATORS, null=True)
master_notes = models.PositiveIntegerField(string_concat('MASTER', ' - ', _('Notes')), null=True)
master_difficulty = models.PositiveIntegerField(string_concat('MASTER', ' - ', _('Difficulty')), validators=DIFFICULTY_VALIDATORS, null=True)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Song model (WIP). Still need to implement associated idols & song type (normal/campaign/event).

@AlexaDeGrandmont AlexaDeGrandmont marked this pull request as ready for review July 22, 2019 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant