Skip to content

Remove promo cards' smaller skill slot limitation. #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sel-en-ium wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove promo cards' smaller skill slot limitation. #332

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c7217a
All promo cards in EN and JP now have access to the same number of sk…
Sel-en-ium Mar 2, 2019
772a93f
I was wrong, Promo R's still have the slot limitation.
Sel-en-ium Apr 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions api/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,9 +569,9 @@ def short_name(self):
SKILL_SLOTS_MINMAX = {
'N': [0, 1, 0],
'R': [1, 2, 1],
'SR': [2, 4, 1],
'SSR': [3, 6, 2],
'UR': [4, 8, 2],
'SR': [2, 4, 4],
'SSR': [3, 6, 6],
'UR': [4, 8, 8],
}

class Card(ExportModelOperationsMixin('Card'), models.Model):
Expand Down Expand Up @@ -650,13 +650,11 @@ class Card(ExportModelOperationsMixin('Card'), models.Model):

@property
def min_skill_slot(self):
if self.is_promo:
return SKILL_SLOTS_MINMAX[self.rarity][2]
return SKILL_SLOTS_MINMAX[self.rarity][0]

@property
def max_skill_slot(self):
if self.is_promo:
if self.is_promo:
return SKILL_SLOTS_MINMAX[self.rarity][2]
return SKILL_SLOTS_MINMAX[self.rarity][1]

Expand Down