Skip to content

Commit 4ef030a

Browse files
Fix import order in serveronly (#3072)
To fix issue caused by #3071 In order to still fulfill the new linter rule `import/order`, I replaced the alias with the path. I also see two other approaches, but I opted for the simplest one here for now. The other approaches: 1. Also create an alias for `app`. 2. Use new `imports` (like in PR #2934), but let `_moduleAliases` untouched to stay compatible to 3rd party modules. **Edit**: Oh, I thought of another option: - Add `require("module-alias/register");`
1 parent 5f38c53 commit 4ef030a

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

CHANGELOG.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ _This release is scheduled to be released on 2023-04-01._
3939
- Update `stylelint` dependencies, switch to `stylelint-config-standard` and handle `stylelint` issues, update `main.css` matching new rules
4040
- Update Eslint config, add new rule and handle issue
4141
- Convert lots of callbacks to async/await
42-
- Revise require imports
42+
- Revise require imports (#3071 and #3072)
4343

4444
### Fixed
4545

@@ -58,7 +58,7 @@ _This release is scheduled to be released on 2023-04-01._
5858
- Fix e2e tests (failed after async changes) by running calendar and newsfeed tests last
5959
- Lint: Use template literals instead of string concatenation
6060
- Fix default alert module to render HTML for title and message
61-
- Fixed Open-Meteo wind speed units
61+
- Fix Open-Meteo wind speed units
6262

6363
## [2.22.0] - 2023-01-01
6464

serveronly/index.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
const Log = require("logger");
21
const app = require("../js/app");
2+
const Log = require("../js/logger");
33

44
app.start().then((config) => {
55
const bindAddress = config.address ? config.address : "localhost";

0 commit comments

Comments
 (0)