fix: network-manager was not listening to device changes

[clotodex]

Just noticed this while implementing the iwd branch. I guess this was not on purpose.

[MalpenZibo]

Ups 😅

[MalpenZibo]

I make some tests. There's something strange. With this fix, something doesn't work well when I switch to a new Wi-Fi, and the system asks for the password. This event is triggered multiple times and asks for the password of the current wifi and for the new one.

I need to investigate more on this O.o sadly the network service is a mess 🥲

[clotodex]

Without checking the code - I ran into a similar thing in IWD.
What happend for me: trying to connect WITH a password can trigger the underlying network to still ask for the password - which would immediately be resolved but STILL trigger a request message in the service code.
In your case specifically this might trigger a device state change but keep it in "needs auth" which triggers the message.
Probably some (print) debugging needed.
And then it obviously gets triggered again when it realizes it needs a password for the new network

This is surprising thought that that was NOT the case before.

[clotodex]

I dont understand the failing CI. Running the same clippy command locally shows no issues.

[MalpenZibo]

I dont understand the failing CI. Running the same clippy command locally shows no issues.

It could be a different clippy version? Have you already tried with a rustup update?

[clotodex]

It could be a different clippy version? Have you already tried with a rustup update?

Actually, given iwd merged, the whole fix needs to be ported to there anyways, let me give that a go to.
Did you get around testing further if this fix did not break anything else?

[MalpenZibo]

The only thing is the wifi password is requested twice.

[clotodex]

That was (is) not the case with the version before?

[MalpenZibo]

The problem doesn't happen in the main version. With this branch, when I switch wifi networks, ashell requests the wifi password twice. I will do more tests to understand why