Skip to content

Conversation

@kavyanekkalapu
Copy link
Member

@kavyanekkalapu kavyanekkalapu commented Jan 13, 2022

Update node version to 16

Issue:ManageIQ/manageiq-ui-classic#7930

@kavyanekkalapu
Copy link
Member Author

@miq-bot assign @Fryguy
@miq-bot add_reviewer @Fryguy
@miq-bot add-label dependencies

@Fryguy Fryguy merged commit cefc666 into ManageIQ:master Feb 21, 2022
@Fryguy
Copy link
Member

Fryguy commented Feb 21, 2022

@agrare I'm not sure how this will play on morphy, where it's still 12, but the plan is for this node 16 stuff to go to najdorf as well.

Also, I think we need to release a bumped version of the gem with this.

@agrare
Copy link
Member

agrare commented Feb 21, 2022

@Fryguy I think we need to get to something like this #87 where we are better at parsing info out of github actions, and we let the workflow define the node version. That PR doesn't do that specifically but moves further in that direction rather than just relying on pre-defined named jobs and language defaults.

agrare added a commit that referenced this pull request Feb 21, 2022
Changes:
- Update nodejs version to v16 (#79)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants