Fix indenting issue in site_menu #1812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
😮 |
|
LOL, so this went red and I think it's exactly for the same reason the last PR went green. I think the build is pulling from master instead of the PR. I'm not sure how to fix this offhand, so I'm ok with merging this on red to get master back to green. @jrafanie it's up to you |
|
Let's merge and see if your instincts are correct. 😉 |
jrafanie
approved these changes
Sep 11, 2024
github-actions bot
pushed a commit
to ManageIQ/manageiq.github.io
that referenced
this pull request
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug introduced in #1806 where the indenting was causing
I don't understand why that PR didn't fail considering it does a full build, but I have a feeling it's not using the PR for the build, but instead using master.
@jrafanie Please review.