Skip to content

Added section to retire the Terraform services #1822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 11, 2024
Merged

Added section to retire the Terraform services #1822

merged 5 commits into from
Dec 11, 2024

Conversation

@qahmed1998
Copy link
Contributor

@qahmed1998 qahmed1998 commented Dec 4, 2024 •
edited
Loading

Added section for "Retire the Terraform services". This topic needs to be visible downstream as well.
@miq-bot assign @Fryguy
@miq-bot add_labels radjabov/yes?

@Fryguy Fryguy assigned putmanoj and unassigned Fryguy Dec 4, 2024
@Fryguy
Copy link
Member

Fryguy commented Dec 4, 2024

@putmanoj Please review.

putmanoj
putmanoj approved these changes Dec 5, 2024
View reviewed changes
Copy link

@putmanoj putmanoj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Editing this comment, as I saw a small change required, after I put this comment

putmanoj
putmanoj suggested changes Dec 5, 2024
View reviewed changes
@qahmed1998
Copy link
Contributor Author

@Fryguy We have the approval. Please merge and backport.

@Fryguy Fryguy closed this Dec 9, 2024
@Fryguy Fryguy reopened this Dec 9, 2024
@mikemoroney
Copy link

Updates LGTM - thanks @qahmed1998

@Fryguy Fryguy merged commit a337d07 into ManageIQ:master Dec 11, 2024
2 checks passed
github-actions bot pushed a commit to ManageIQ/manageiq.github.io that referenced this pull request Dec 11, 2024
Deploy for ManageIQ/manageiq-documentation#1822
fef066e
@Fryguy
Copy link
Member

Fryguy commented Dec 11, 2024

Backported to radjabov in commit f749e75.

commit f749e756f77658af7503cf2cd9700a4360e20c4b
Author: Jason Frey <fryguy9@gmail.com>
Date:   Wed Dec 11 13:34:10 2024 -0500

    Merge pull request #1822 from qahmed1998/QA-add-service-catalog-retirement
    
    Added section to retire the Terraform services
    
    (cherry picked from commit a337d070f0b6e28eb85b3806dc345d3ffd1cfaba)

Fryguy added a commit that referenced this pull request Dec 11, 2024
@Fryguy
Merge pull request #1822 from qahmed1998/QA-add-service-catalog-retir…
f749e75 
…ement

Added section to retire the Terraform services

(cherry picked from commit a337d07)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@putmanoj putmanoj putmanoj requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@putmanoj putmanoj

Labels

enhancement radjabov/backported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@qahmed1998 @Fryguy @mikemoroney @putmanoj @miq-bot