Skip to content

[WIP] bypass feature validation for dynamic tenant features #9523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jrafanie
Copy link
Member

No description provided.

@jrafanie jrafanie requested a review from a team as a code owner July 22, 2025 20:13
@jrafanie jrafanie added the wip label Jul 22, 2025
@Fryguy Fryguy changed the title WIP - bypass feature validation for dynamic tenant features [WIP] bypass feature validation for dynamic tenant features Jul 22, 2025
@Fryguy
Copy link
Member

Fryguy commented Jul 23, 2025

As discussed

tactically, if we change the role_allows to use x_node it would eliminate the params code, and it should just work...long term, there's gotta be a better way that avoids override role_allows at all, and passing in the correct feature from the caller

role_allows shouldn't be dynamically be building features though - something else should be doing that - I'm not sure how the toolbar code is working though
what I think has to happen long term, is we shouldn't be using basic buttons, but should have custom subclasses of the button for tenant stuff

@jrafanie
Copy link
Member Author

Closing in favor of #9527

@jrafanie jrafanie closed this Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants