Skip to content

Refactor parameter names and clean up docs #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 31 commits into from
Sep 27, 2024
Merged

Refactor parameter names and clean up docs #221

merged 31 commits into from
Sep 27, 2024

Conversation

amochin
Copy link
Collaborator

@amochin amochin commented Sep 27, 2024

@amochin
Keyword "Connect to database" - custom params and config file refacto…
3caffd1 
…ring
@amochin
Connection params tests - fix expected error messages for pymysql
455ddce
@amochin
minor docs improvements
b543fb9
@amochin
Stop using '{SQL Server}' as fallback value for pyodbc driver
e7096e6
@amochin
Small bugfix in logging - avoid losing the last bracket after hiding …
c78e1e0 
…the password, if it was the last parameter
@amochin
Connection tests - MySQL has own error message when charset is invalid
1475941
@amochin
Fix setting the con_str for pyodbc
ff97767
@amochin
Fix connection logging for excel
dcdc5b4
@amochin
Make connection params optional for pyodbc as well (using connection …
1dfb77f 
…string)
@amochin
Tests - wrong comma in expected error message
501164b
@amochin
Fix hiding pass value in logging connection string
36e2550
@amochin
Make connection params tests work also for pyodbc
946c259
@amochin
Fix connection params tests for pyodbc
1bb5ecc
@amochin
Fix connection params tests for pyodbc again
1c45681
@amochin
optimize module import condition for "excel"
32b91b8
@amochin
Update unit tests
f93f1cd
@amochin
Check "if not None" for not set args instead of bool way is more precise
166befa
@amochin
Update docs
21343db
@amochin
Typo
47d0f33
@amochin
Pythonic naming for keyword arguments (fix #188)
b0e6b26
@amochin
Deprecate using too many positional args
2645ed5
@amochin
Rename "python_module" to "db_module"
090fdd1
@amochin
Support deprecated arguments in config file
822a31e
@amochin
Revert "Deprecate using too many positional args"
3659bb2 
This reverts commit 2645ed5.
@amochin
Clean up docs and last params
70f2466
@amochin
Improve docs a bit
b9867c8
@amochin
Improve docs a bit
cc57abd
@amochin
Docs and readme update
1a268fb
@amochin
Fix and align docs and readme
1b2912f
@amochin
Align code examples in readme closely
6c526db
@amochin amochin merged commit 611b1d0 into dev Sep 27, 2024
20 checks passed
@amochin amochin deleted the refactor-param-names branch September 27, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@amochin