DHFPROD-4830: Check for false positives on search for multiple merge actions on document (#4009)

Author: ryanjdew

marklogic-data-hub/src/main/resources/ml-modules/root/data-hub/5/builtins/steps/mastering/default/merging.sjs

@@ -55,10 +55,16 @@ function main(content, options) {
         uriRangeQuery
       ),
       ['unfiltered',cts.indexOrder(datahubCreatedOnRef, 'descending')]
-    ).toArray().map(
-      (result) => result.xpath(`/matchSummary/actionDetails/*[action = 'merge']`).toArray()
-        .filter((actionNode) => cts.contains(actionNode, urisQuery))[0].toObject()
-    );
+    ).toArray()
+        // get the actionNode for the URI
+        .map(
+          (result) => result.xpath(`/matchSummary/actionDetails/*[action = 'merge']`).toArray()
+            .filter((actionNode) => cts.contains(actionNode, urisQuery))[0]
+        )
+        // filter out false positives that don't have merge actions for the given URI
+        .filter((actionNode) => !!actionNode)
+        // convert node to JSON object
+        .map((actionNode) => actionNode.toObject());
     if (otherMergesForURI.some((otherMerge) => otherMerge.uris.length > uriActionDetails.uris.length)) {
       return Sequence.from([]);
     }

marklogic-data-hub/src/test/ml-modules/root/test/suites/data-hub/5/builtins/steps/mastering/default/merging/falsePositivesForOtherMerges.sjs

@@ -0,0 +1,12 @@
+const merging = require("/data-hub/5/builtins/steps/mastering/default/merging.sjs");
+const test = require("/test/test-helper.xqy");
+
+const assertions = [];
+let caughtException = null;
+try {
+    merging.main({uri: '/merge-with-doc1.json'}, {mergeOptions: {}});
+} catch (e) {
+    caughtException = e;
+}
+assertions.push(test.assertFalse(!!caughtException, `Call threw exception unexpectedly. (Exception: ${caughtException})`));
+assertions;

marklogic-data-hub/src/test/ml-modules/root/test/suites/data-hub/5/builtins/steps/mastering/default/merging/suiteSetup.sjs

@@ -0,0 +1,93 @@
+declareUpdate();
+
+// Inserting documents into final database
+xdmp.documentInsert("/matchSummary1.json",
+    {
+        "matchSummary": {
+            "URIsToProcess": [
+                "/merge-with-doc1.json",
+                "/doc2.json"
+            ],
+            "actionDetails": {
+                "/merge-with-doc1.json": {
+                    "action": "merge",
+                    "uris": [
+                        "/match1.json",
+                        "/match2.json"
+                    ]
+                },
+                "/doc2.json": {
+                    "action": "notify",
+                    "uris": [
+                        "/match3.json",
+                        "/match4.json"
+                    ]
+                }
+            }
+        }
+    },
+    {
+        permissions: xdmp.defaultPermissions(),
+        collections: ["datahubMasteringMatchSummary"],
+        metadata: {
+            // add 1 hr to ensure this is selected first
+            "datahubCreatedOn": fn.currentDateTime().add(xs.dayTimeDuration('P0DT1H'))
+        }
+    });
+
+xdmp.documentInsert("/matchSummary2.json",
+    {
+        "matchSummary": {
+            "URIsToProcess": [
+                "/notify-with-doc1.json",
+                "/doc2.json"
+            ],
+            "actionDetails": {
+                "/notify-with-doc1.json": {
+                    "action": "notify",
+                    "uris": [
+                        "/match1.json",
+                        "/match2.json"
+                    ]
+                },
+                "/doc2.json": {
+                    "action": "merge",
+                    "uris": [
+                        "/match3.json",
+                        "/match4.json"
+                    ]
+                }
+            }
+        }
+    },
+    {
+        permissions: xdmp.defaultPermissions(),
+        collections: ["datahubMasteringMatchSummary"],
+        metadata: {
+            "datahubCreatedOn": fn.currentDateTime()
+        }
+    });
+
+xdmp.documentInsert('/match1.json',
+    {
+        envelope: { instance: { minimalDoc: 'value'}}
+    },
+    {
+    permissions: xdmp.defaultPermissions(),
+    collections: ["test-doc"],
+    metadata: {
+        "datahubCreatedOn": fn.currentDateTime()
+    }
+});
+
+xdmp.documentInsert('/match2.json',
+    {
+        envelope: { instance: { minimalDoc: 'value'}}
+    },
+    {
+        permissions: xdmp.defaultPermissions(),
+        collections: ["test-doc"],
+        metadata: {
+            "datahubCreatedOn": fn.currentDateTime()
+        }
+    })

marklogic-data-hub/src/test/ml-modules/root/test/suites/data-hub/5/builtins/steps/mastering/default/merging/suiteTeardown.sjs

@@ -0,0 +1,5 @@
+declareUpdate();
+
+xdmp.collectionDelete('test-doc');
+
+xdmp.collectionDelete('datahubMasteringMatchSummary');