Skip to content

♻️ Refactor Comwatt client usage to avoid multiple instances #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

MateoGreil
Copy link
Owner

@MateoGreil MateoGreil commented Jan 27, 2025

This pull request addresses the issue of creating multiple instances of the Comwatt client and handles disconnection scenarios that require re-authentication.

Could fix : #36

These changes ensure that a single instance of the Comwatt client is used throughout the integration and that disconnections are properly handled by re-authenticating and updating the session cookies. This should resolve issues related to disconnections and the need for manual resets.

@MateoGreil MateoGreil self-assigned this Jan 27, 2025
@MateoGreil MateoGreil force-pushed the fix/shared-client branch 2 times, most recently from 3a9fde6 to ee9c552 Compare January 27, 2025 17:17
@MateoGreil MateoGreil changed the title Fix/shared client ♻️ Refactor Comwatt client usage to avoid multiple instances Jan 27, 2025
@MateoGreil MateoGreil marked this pull request as ready for review January 27, 2025 17:30
@MateoGreil MateoGreil merged commit e2b51e5 into main Jan 29, 2025
4 checks passed
@MateoGreil MateoGreil deleted the fix/shared-client branch January 29, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating comwatt sensor took longer than the scheduled
1 participant