[test] SLT rewrites #33820
Open
[test] SLT rewrites #33820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No reason not to get the additional coverage, plus this makes results more consistent between environments. (SLTs sometimes include debug info, which is a bit questionable, but does happen...)
|
The most recent discussion on this: https://github.com/MaterializeInc/database-issues/issues/8097#issuecomment-2720688239 So, if I understand correctly, the change that this PR makes is that when running the slts locally, |
def-
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Running these in debug and release mode, or with different env vars set, can result in different output due to our debug data redaction. It's a little weird that our debug representations filter up into user-facing SQL output like this - it seems like debug should normally be an internal thing - but anyways setting this env var will ensure that we get the full unredacted output from our SLTs and also run the maximum of assertions.