[repr types] migrate transform::typecheck
#33871
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A first cut at moving the optimizer over to representation types. My general plan is to migrate everything but the ASTs, starting with transforms and then moving to other parts of the system.
I'm starting with the most type-intensive transform: the typechecker.
Motivation
Tips for reviewer
There's some chaff around
ScalarBaseType
and other fiddly bits that #33557 didn't quite get to... sorry! 🥲Checklist
$T ⇔ Proto$T
mapping (possibly in a backwards-incompatible way), then it is tagged with aT-proto
label.