Update convert.js to fix incorrect handling of some images #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this script uses the "latex_styled" response field to extract the output. but for some images the "latex_styled" field is not return, only the "text" is returned for such images it fails with the "could not write to destination path" error (with the incorrect error message). this commit fixes this by using the "text" field if the "latex_styled" field is not available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this script uses the "latex_styled" response field to extract the output. but for some images the "latex_styled" field is not return, only the "text" is returned for such images it fails with the "could not write to destination path" error (with the incorrect error message).
this commit fixes this by using the "text" field if the "latex_styled" field is not available.
example of the failing image is attached (check with ocr api mode, not with snip mode)
for this image, only the text field is return, latex_styled is not.