Open
Conversation
-Added: A way to create a Panel without adding it into the probe. -Added: Turning a ProbeInfo into a Element so you can actually add it without a unsave cast.
Contributor
Author
|
@McJty do you plan to implement something like this into your "IStyleManager" or create like something "IElementManager"? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Added: A way to create a Panel without adding it into the probe.
-Added: Turning a ProbeInfo into a Element so you can actually add it without a unsave cast.
Reason i add this:
If you want to fully control how elements are added you have to use the API implementation there is no way to add a element without 5 extra steps to just create a panel without adding it to the current info.
Also this new feature requires that IProbeInfos are convertable to IElement so you can actually add them.
This provides a lot more control.
Note: This could break custom implementations if they didn't implement the new API methods.
Another note: This technically could be moved into the "Style" Creator API if wanted. But this would not work idealy with dynamic data. Though maybe i am adding that later to it.